verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 59 Releases Wiki Activity

#7108 - exchange-rate #2295

Merged
jgallego merged 11 commits from 7108-exchange-rate into dev 2024-04-26 05:00:07 +00:00
Conversation 0 Commits 11 Files Changed 9 +5 -22
3 changed files with 5 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit e8001b72e4 - Show all commits

13
back/methods/collection/exchangeRateUpdate.js
View File

@ -10,11 +10,6 @@ module.exports = Self => {
http: { http: {
path: '/exchangeRateUpdate', path: '/exchangeRateUpdate',
verb: 'post' verb: 'post'
},
returns: {
arg: 'result',
type: 'object',
root: true
} }
}); });
jgallego marked this conversation as resolved Outdated
alexm commented 2024-04-12 08:35:31 +00:00
Outdated
Review
Copy Link

Si no retorna res, no cal ficar return (no estic segur)

Si no retorna res, no cal ficar return (no estic segur)
@ -29,16 +24,14 @@ module.exports = Self => {
const maxDateRecord = await models.ReferenceRate.findOne({order: 'dated DESC'}); const maxDateRecord = await models.ReferenceRate.findOne({order: 'dated DESC'});
const maxDate = maxDateRecord && maxDateRecord.dated ? new Date(maxDateRecord.dated) : null; const maxDate = maxDateRecord?.dated ? new Date(maxDateRecord.dated) : null;
for (let i = 0; i < cubes.length; i++) { for (const cube of Array.from(cubes)) {
const cube = cubes[i];
if (cube.nodeType === 1 && cube.attributes.getNamedItem('time')) { if (cube.nodeType === 1 && cube.attributes.getNamedItem('time')) {
const xmlDate = new Date(cube.getAttribute('time')); const xmlDate = new Date(cube.getAttribute('time'));
const xmlDateWithoutTime = new Date(xmlDate.getFullYear(), xmlDate.getMonth(), xmlDate.getDate()); const xmlDateWithoutTime = new Date(xmlDate.getFullYear(), xmlDate.getMonth(), xmlDate.getDate());
jgallego marked this conversation as resolved Outdated
alexm commented 2024-04-12 08:36:29 +00:00
Outdated
Review
Copy Link

Se pot simplificar en const maxDate = maxDateRecord?.dated ? new Date(maxDateRecord.dated) : null;

Se pot simplificar en `const maxDate = maxDateRecord?.dated ? new Date(maxDateRecord.dated) : null;`
jgallego commented 2024-04-13 06:44:53 +00:00
Outdated
Review
Copy Link

const maxDate = maxDateRecord?.dated ? new Date(maxDateRecord.dated) : null;

Unhandled error for request POST /api/Collections/exchangeRateUpdate?access_token=YQ8SPYxYrHrY4veSEyY5q9YJD3AtcjEqcGXxyA5rweDZO92PLp0FB2WhBxlbTvUO: TypeError: Cannot read properties of null (reading 'dated')

Ahir em va fallar..ací t'he posat la conversa amb chatGpt...ara sí va..ho canvie de nou

const maxDate = maxDateRecord?.dated ? new Date(maxDateRecord.dated) : null; Unhandled error for request POST /api/Collections/exchangeRateUpdate?access_token=YQ8SPYxYrHrY4veSEyY5q9YJD3AtcjEqcGXxyA5rweDZO92PLp0FB2WhBxlbTvUO: TypeError: Cannot read properties of null (reading 'dated') Ahir em va fallar..ací t'he posat la conversa amb chatGpt...ara sí va..ho canvie de nou
if (!maxDate || maxDate < xmlDateWithoutTime) { if (!maxDate || maxDate < xmlDateWithoutTime) {
for (let j = 0; j < cube.childNodes.length; j++) { for (const rateCube of Array.from(cube.childNodes)) {
jgallego marked this conversation as resolved Outdated
alexm commented 2024-04-12 08:34:44 +00:00
Outdated
Review
Copy Link

Si no cal la "i" i la "j", vec mes legible fer:

for (const/let cube of cubes)

i lo mateix en el altre for

Si no cal la "i" i la "j", vec mes legible fer: ``` for (const/let cube of cubes) ``` i lo mateix en el altre for
jgallego commented 2024-04-13 06:52:40 +00:00
Outdated
Review
Copy Link

no era iterable li he posat Array.from(

no era iterable li he posat Array.from(
const rateCube = cube.childNodes[j];
if (rateCube.nodeType === doc.ELEMENT_NODE) { if (rateCube.nodeType === doc.ELEMENT_NODE) {
const currencyCode = rateCube.getAttribute('currency'); const currencyCode = rateCube.getAttribute('currency');
const rate = rateCube.getAttribute('rate'); const rate = rateCube.getAttribute('rate');

1
back/models/reference-rate.json
View File

@ -1,7 +1,6 @@
{ {
"name": "ReferenceRate", "name": "ReferenceRate",
"base": "PersistedModel", "base": "PersistedModel",
"idInjection": false,
"options": { "options": {
jgallego marked this conversation as resolved
alexm commented 2024-04-12 08:32:05 +00:00
Review
Copy Link

esta propietat no la havia vist mai

esta propietat no la havia vist mai
"mysql": { "mysql": {
"table": "referenceRate" "table": "referenceRate"

13
loopback/locale/es.json
View File

@ -352,14 +352,5 @@
"The line could not be marked": "La linea no puede ser marcada", "The line could not be marked": "La linea no puede ser marcada",
"This password can only be changed by the user themselves": "Esta contraseña solo puede ser modificada por el propio usuario", "This password can only be changed by the user themselves": "Esta contraseña solo puede ser modificada por el propio usuario",
"They're not your subordinate": "No es tu subordinado/a.", "They're not your subordinate": "No es tu subordinado/a.",
"No results found": "No se han encontrado resultados", "No results found": "No se han encontrado resultados"
"ReferenceError: app is not defined": "ReferenceError: app is not defined", }
"TypeError: Cannot read properties of undefined (reading 'ReferenceRate')": "TypeError: Cannot read properties of undefined (reading 'ReferenceRate')",
"Error: ER_BAD_FIELD_ERROR: Unknown column 'date' in 'order clause'": "Error: ER_BAD_FIELD_ERROR: Unknown column 'date' in 'order clause'",
"ReferenceError: ReferenceRate is not defined": "ReferenceError: ReferenceRate is not defined",
"ValidationError: The `ReferenceRate` instance is not valid. Details: `currencyFk` can't be blank (value: NaN).": "ValidationError: The `ReferenceRate` instance is not valid. Details: `currencyFk` can't be blank (value: NaN).",
"ReferenceError: Currency is not defined": "ReferenceError: Currency is not defined",
"UserError: Currency not found for code: CNY": "UserError: Currency not found for code: CNY",
"Error: ER_DUP_ENTRY: Duplicate entry '2-2024-04-03' for key 'PRIMARY'": "Error: ER_DUP_ENTRY: Duplicate entry '2-2024-04-03' for key 'PRIMARY'",
"Error: ER_DUP_ENTRY: Duplicate entry '2-2024-04-08' for key 'PRIMARY'": "Error: ER_DUP_ENTRY: Duplicate entry '2-2024-04-08' for key 'PRIMARY'"
}