verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refs #4409 Remove old recalc code #2300

Merged
juan merged 9 commits from 4409-binlog into dev 2024-04-22 19:45:20 +00:00
Conversation 0 Commits 9 Files Changed 52 +198 -490
juan commented 2024-04-15 07:46:31 +00:00
Owner
Copy Link
No description provided.
juan added 2 commits 2024-04-15 07:46:32 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
9da9478daf Merge branch 'dev' into 4409-binlog
juan added 1 commit 2024-04-15 08:22:08 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
133d45eecf Merge branch 'dev' into 4409-binlog
juan added 1 commit 2024-04-17 11:21:32 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
ae326e6e2e feat(binlog): refs #4409 Old recalc code removed 
Queues: orderTotal, ticketTotal and travelEntries
juan added 1 commit 2024-04-17 11:24:35 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
7cda14c424 Merge branch 'dev' into 4409-binlog
juan changed title from WIP: refs #4409 to refs #4409 Remove old recalc code 2024-04-17 11:26:42 +00:00
juan requested review from carlosap 2024-04-17 11:26:56 +00:00
juan requested review from jgallego 2024-04-17 11:27:02 +00:00
jgallego approved these changes 2024-04-17 11:34:17 +00:00
Dismissed
jgallego left a comment
Owner
Copy Link

La unica cosa a comentar es que aqui no has usado create or replace, pero imagino que no aporta nada
CREATE PROCEDURE tmp.ticket_recalc

La unica cosa a comentar es que aqui no has usado create or replace, pero imagino que no aporta nada CREATE PROCEDURE `tmp`.`ticket_recalc`
carlosap requested changes 2024-04-18 11:34:23 +00:00
Dismissed
db/dump/fixtures.before.sql Outdated
@ -2626,2 +2625,3 @@
DECLARE vTicketFk INT;
CALL `vn`.`ticket_doRecalc`();
DECLARE cCur CURSOR FOR SELECT id FROM vn.ticket;
carlosap commented 2024-04-18 11:27:24 +00:00
Member
Copy Link

Nombre del cursor

Nombre del cursor
juan marked this conversation as resolved
juan added 1 commit 2024-04-19 12:19:47 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
a0126748e2 fix(binlog): refs #4409 Fix fixtures cursor name
juan requested review from carlosap 2024-04-19 12:20:09 +00:00
juan requested review from jgallego 2024-04-19 12:20:11 +00:00
jgallego approved these changes 2024-04-19 12:26:33 +00:00
carlosap requested changes 2024-04-21 09:18:54 +00:00
Dismissed
db/routines/vn/procedures/ticket_recalcByScope.sql Outdated
@ -0,0 +22,4 @@
DECLARE CONTINUE HANDLER FOR NOT FOUND
SET vDone = TRUE;
OPEN cCur;
carlosap commented 2024-04-21 09:18:49 +00:00
Member
Copy Link

cCur -> cTickets

cCur -> cTickets
juan marked this conversation as resolved
juan added 1 commit 2024-04-22 06:54:43 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
bc45cafb40 Merge branch 'dev' into 4409-binlog
juan added 1 commit 2024-04-22 07:02:49 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
739ae82ace fix(binlog): refs #4409 Fix cursor name
juan requested review from carlosap 2024-04-22 07:03:13 +00:00
carlosap approved these changes 2024-04-22 12:19:03 +00:00
juan added 1 commit 2024-04-22 19:43:51 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
d58607f26e Merge branch 'dev' into 4409-binlog
juan merged commit 91608b9053 into dev 2024-04-22 19:45:20 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
carlosap
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2300
No description provided.
Delete Branch "4409-binlog"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?