verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

feat: refs #6968 Changed groupingMode to enum #2306

Merged
guillermo merged 3 commits from 6968-groupingModeRefactor into dev 2024-04-17 06:48:44 +00:00
Conversation 0 Commits 3 Files Changed 19 +78 -84
guillermo commented 2024-04-16 09:07:59 +00:00
Member
Copy Link
No description provided.
guillermo added 1 commit 2024-04-16 09:08:00 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
7a557be09a feat: refs #6968 Changed groupingMode to enum
guillermo requested review from jgallego 2024-04-16 09:36:43 +00:00
jgallego approved these changes 2024-04-16 13:21:13 +00:00
Dismissed
db/routines/vn/procedures/catalog_componentCalculate.sql
@ -49,3 +49,3 @@
IFNULL(pf.packing, GREATEST(b.grouping, b.packing)) packing,
IFNULL(pf.`grouping`, b.`grouping`) `grouping`,
ABS(IFNULL(pf.box, b.groupingMode)) groupingMode,
b.groupingMode groupingMode,
jgallego commented 2024-04-16 13:01:51 +00:00
Owner
Copy Link

i pf.box?

i pf.box?
guillermo commented 2024-04-17 05:14:19 +00:00
Author
Member
Copy Link

Tots son null

Tots son null
guillermo marked this conversation as resolved
db/routines/vn/procedures/sale_replaceItem.sql Outdated
@ -14,3 +14,3 @@
DECLARE vDate DATE;
DECLARE vGrouping INT;
DECLARE vGroupingModeFk INT;
DECLARE vGroupingModeFk VARCHAR(255);
jgallego commented 2024-04-16 13:04:14 +00:00
Owner
Copy Link

vGroupingMode no es una Fk

vGroupingMode no es una Fk
guillermo marked this conversation as resolved
guillermo added 1 commit 2024-04-17 05:15:21 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
c8e7706652 feat: refs #6968 Requested changes
guillermo requested review from jgallego 2024-04-17 05:15:28 +00:00
guillermo added 1 commit 2024-04-17 05:15:40 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
d92d373db4 Merge branch 'dev' into 6968-groupingModeRefactor
jgallego approved these changes 2024-04-17 06:21:35 +00:00
guillermo merged commit 9f9662924d into dev 2024-04-17 06:48:44 +00:00
guillermo deleted branch 6968-groupingModeRefactor 2024-04-17 06:48:44 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2306
No description provided.
Delete Branch "6968-groupingModeRefactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?