refs #7191 check isBooked in entry_BeforeUpdate #2329

Merged
ivanm merged 9 commits from 7191-entry_BeforeUpdate-isBooked into dev 2024-05-03 12:59:13 +00:00
Member
No description provided.
ivanm added 1 commit 2024-04-18 14:13:01 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
7e488ee601
refs #7191 check isBooked in entry_BeforeUpdate
ivanm added 1 commit 2024-04-19 09:47:55 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
00ce018ee3
Merge branch 'dev' into 7191-entry_BeforeUpdate-isBooked
ivanm requested review from carlosap 2024-04-19 10:31:06 +00:00
carlosap requested changes 2024-04-21 10:02:51 +00:00
Dismissed
@ -6,11 +6,20 @@ BEGIN
DECLARE vIsVirtual BOOL;
DECLARE vPrintedCount INT;
DECLARE vHasDistinctWarehouses BOOL;
DECLARE vEntryFkCount INT;
Member

El que estem contant son buy no entry, seria més descriptiu buyCounter ó totalBuy

El que estem contant son buy no entry, seria més descriptiu buyCounter ó totalBuy
ivanm marked this conversation as resolved
@ -11,3 +12,4 @@
CALL entry_checkBooked(OLD.id);
END IF;
IF NEW.isBooked = 1 THEN
Member

No es te que mirar sempre que siga TRUE, es deu de mirar sempre que cambie de valor y el nou siga TRUE

No es te que mirar sempre que siga TRUE, es deu de mirar sempre que cambie de valor y el nou siga TRUE
ivanm marked this conversation as resolved
ivanm added 1 commit 2024-04-22 13:05:54 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
0284b138d7
refs #7191 requested modifications
ivanm added 1 commit 2024-04-22 13:08:09 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
f03a431ea2
Merge branch 'dev' into 7191-entry_BeforeUpdate-isBooked
ivanm requested review from carlosap 2024-04-22 13:09:35 +00:00
ivanm added 1 commit 2024-04-29 17:43:35 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
30f6a9324d
refs #7191 SQL conventions mod
ivanm added 1 commit 2024-04-29 17:46:28 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
a33cbb0a7c
Merge branch 'dev' into 7191-entry_BeforeUpdate-isBooked
carlosap requested review from guillermo 2024-04-29 18:05:21 +00:00
guillermo requested changes 2024-04-30 05:06:27 +00:00
Dismissed
@ -12,0 +15,4 @@
SELECT COUNT(*) INTO vTotalBuy
FROM buy
WHERE entryFk = NEW.id;
IF vTotalBuy = 0 THEN
Member

IF NOT vTotalBuy THEN

IF NOT vTotalBuy THEN
ivanm marked this conversation as resolved
@ -12,0 +16,4 @@
FROM buy
WHERE entryFk = NEW.id;
IF vTotalBuy = 0 THEN
CALL util.throw('The entry cannot be marked as booked if it does not have lines');
Member

Acortar msg del throw, lo máximo que permite el procedimiento son 55 carácteres

Acortar msg del throw, lo máximo que permite el procedimiento son 55 carácteres
ivanm marked this conversation as resolved
ivanm added 1 commit 2024-04-30 12:39:59 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
3167bdcdd0
refs #7191 message modification
ivanm added 1 commit 2024-04-30 12:41:56 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
de5e43fb05
Merge branch 'dev' into 7191-entry_BeforeUpdate-isBooked
ivanm requested review from guillermo 2024-04-30 12:45:50 +00:00
guillermo approved these changes 2024-04-30 12:49:44 +00:00
carlosap approved these changes 2024-05-03 12:48:05 +00:00
ivanm added 1 commit 2024-05-03 12:57:29 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
5d3235977f
Merge branch 'dev' into 7191-entry_BeforeUpdate-isBooked
ivanm merged commit 5643a2e9e2 into dev 2024-05-03 12:59:13 +00:00
ivanm deleted branch 7191-entry_BeforeUpdate-isBooked 2024-05-03 12:59:13 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2329
No description provided.