verdnatura/salix
verdnatura
/
salix
3
5
Fork 0
Code Issues Pull Requests 64 Releases Wiki Activity

refs #7191 check isBooked in entry_BeforeUpdate #2329

Merged
ivanm merged 9 commits from 7191-entry_BeforeUpdate-isBooked into dev 2024-05-03 12:59:13 +00:00
Conversation 0 Commits 9 Files Changed 1 +8 -8
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 0284b138d7 - Show all commits

16
db/routines/vn/triggers/entry_beforeUpdate.sql
View File

@ -6,17 +6,17 @@ BEGIN
DECLARE vIsVirtual BOOL;
DECLARE vPrintedCount INT;
DECLARE vHasDistinctWarehouses BOOL;
DECLARE vEntryFkCount INT;
DECLARE vTotalBuy INT;
ivanm marked this conversation as resolved Outdated
carlosap commented 2024-04-21 09:39:05 +00:00
Outdated
Review
Copy Link

El que estem contant son buy no entry, seria més descriptiu buyCounter ó totalBuy

El que estem contant son buy no entry, seria més descriptiu buyCounter ó totalBuy
IF NEW.isBooked = OLD.isBooked THEN
CALL entry_checkBooked(OLD.id);
END IF;
IF NEW.isBooked = 1 THEN
SELECT COUNT(*) INTO vEntryFkCount
FROM buy WHERE entryFk = NEW.id;
IF vEntryFkCount = 0 THEN
CALL util.throw('The entry cannot be marked as booked if it does not have lines');
ELSE
IF NEW.isBooked = 1 THEN
SELECT COUNT(*) INTO vTotalBuy
ivanm marked this conversation as resolved Outdated
carlosap commented 2024-04-21 10:02:43 +00:00
Outdated
Review
Copy Link

No es te que mirar sempre que siga TRUE, es deu de mirar sempre que cambie de valor y el nou siga TRUE

No es te que mirar sempre que siga TRUE, es deu de mirar sempre que cambie de valor y el nou siga TRUE
FROM buy WHERE entryFk = NEW.id;
IF vTotalBuy = 0 THEN
CALL util.throw('The entry cannot be marked as booked if it does not have lines');
ivanm marked this conversation as resolved Outdated
guillermo commented 2024-04-30 05:05:54 +00:00
Outdated
Review
Copy Link

IF NOT vTotalBuy THEN

IF NOT vTotalBuy THEN
END IF;
ivanm marked this conversation as resolved Outdated
guillermo commented 2024-04-30 05:05:25 +00:00
Outdated
Review
Copy Link

Acortar msg del throw, lo máximo que permite el procedimiento son 55 carácteres

Acortar msg del throw, lo máximo que permite el procedimiento son 55 carácteres
END IF;
END IF;