verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 59 Releases Wiki Activity

refs #7191 check isBooked in entry_BeforeUpdate #2329

Merged
ivanm merged 9 commits from 7191-entry_BeforeUpdate-isBooked into dev 2024-05-03 12:59:13 +00:00
Conversation 0 Commits 9 Files Changed 1 +3 -3
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 3167bdcdd0 - Show all commits

6
db/routines/vn/triggers/entry_beforeUpdate.sql
View File

@ -15,8 +15,8 @@ BEGIN
SELECT COUNT(*) INTO vTotalBuy SELECT COUNT(*) INTO vTotalBuy
ivanm marked this conversation as resolved Outdated
carlosap commented 2024-04-21 10:02:43 +00:00
Outdated
Review
Copy Link

No es te que mirar sempre que siga TRUE, es deu de mirar sempre que cambie de valor y el nou siga TRUE

No es te que mirar sempre que siga TRUE, es deu de mirar sempre que cambie de valor y el nou siga TRUE
FROM buy FROM buy
WHERE entryFk = NEW.id; WHERE entryFk = NEW.id;
IF vTotalBuy = 0 THEN IF NOT vTotalBuy THEN
ivanm marked this conversation as resolved Outdated
guillermo commented 2024-04-30 05:05:54 +00:00
Outdated
Review
Copy Link

IF NOT vTotalBuy THEN

IF NOT vTotalBuy THEN
CALL util.throw('The entry cannot be marked as booked if it does not have lines'); CALL util.throw('Entry must have lines to be marked booked');
ivanm marked this conversation as resolved Outdated
guillermo commented 2024-04-30 05:05:25 +00:00
Outdated
Review
Copy Link

Acortar msg del throw, lo máximo que permite el procedimiento son 55 carácteres

Acortar msg del throw, lo máximo que permite el procedimiento son 55 carácteres
END IF; END IF;
END IF; END IF;
END IF; END IF;
@ -26,7 +26,7 @@ BEGIN
IF NOT (NEW.travelFk <=> OLD.travelFk) THEN IF NOT (NEW.travelFk <=> OLD.travelFk) THEN
IF NEW.travelFk IS NOT NULL AND NOT travel_hasUniqueAwb(NEW.travelFk) THEN IF NEW.travelFk IS NOT NULL AND NOT travel_hasUniqueAwb(NEW.travelFk) THEN
CALL util.throw('The travel is incorrect, there is a different AWB in the associated entries'); CALL util.throw('The travel is incorrect, there is a different AWB in the associated entries');
END IF; END IF;
SELECT COUNT(*) > 0 INTO vIsVirtual SELECT COUNT(*) > 0 INTO vIsVirtual