verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refactor: refs #7258 Deleted all dependences of vn2008 schema #2362

Merged
guillermo merged 7 commits from 7258-lastChangesMigrationVn2008 into dev 2024-04-30 05:37:34 +00:00
Conversation 1 Commits 7 Files Changed 47 +222 -1085
guillermo commented 2024-04-24 07:53:33 +00:00
Member
Copy Link
No description provided.
guillermo added 1 commit 2024-04-24 07:53:34 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
f7ebd071bf refactor: #7258 Deleted all dependences of vn2008 schema
guillermo added 1 commit 2024-04-24 07:53:50 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
4cc6b2f4f2 Merge branch 'dev' into 7258-lastChangesMigrationVn2008
guillermo changed title from refactor: #7258 Deleted all dependences of vn2008 schema to refactor: refs #7258 Deleted all dependences of vn2008 schema 2024-04-24 08:16:16 +00:00
guillermo added 1 commit 2024-04-24 08:16:37 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
7a1c8ebc7f Merge branch 'dev' into 7258-lastChangesMigrationVn2008
guillermo added 2 commits 2024-04-24 08:57:26 +00:00
guillermo requested review from carlosap 2024-04-24 08:57:38 +00:00
guillermo added 1 commit 2024-04-24 09:27:06 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
6fb87531c4 refactor: #7258 Deprecated last tables vn2008
guillermo commented 2024-04-24 09:28:48 +00:00
Author
Member
Copy Link

@carlosap No me he parado a refactorizar cada objeto que modificaba, ya que si no la tarea se iba de tiempo.
Lo digo por cuando te pongas a revisar el PR 🤪

@carlosap No me he parado a refactorizar cada objeto que modificaba, ya que si no la tarea se iba de tiempo. Lo digo por cuando te pongas a revisar el PR 🤪
carlosap requested changes 2024-04-24 16:31:59 +00:00
Dismissed
db/routines/bs/procedures/ventas_contables_add.sql
@ -70,0 +66,4 @@
AND s.price <> 0
AND s.discount <> 100
AND i.typeFk <> TIPO_PATRIMONIAL
GROUP BY grupo, it.categoryFk, i.typeFk, t.companyFk, Gasto;
carlosap commented 2024-04-24 16:31:34 +00:00
Member
Copy Link

grupo¿?

grupo¿?
guillermo commented 2024-04-25 05:00:48 +00:00
Author
Member
Copy Link

Sí, si te fijas hace referencia a un alias, es una columna calculada, no hace referencia a una columna de una tabla en si

Sí, si te fijas hace referencia a un alias, es una columna calculada, no hace referencia a una columna de una tabla en si
guillermo marked this conversation as resolved
db/routines/vn/procedures/item_cleanFloramondo.sql Outdated
@ -101,9 +101,6 @@ BEGIN
DELETE FROM itemCost
WHERE itemFk = vItemOld;
DELETE FROM vn2008.rec_translator
carlosap commented 2024-04-24 16:24:13 +00:00
Member
Copy Link

No se sustituye por nada?

No se sustituye por nada?
guillermo commented 2024-04-25 05:01:49 +00:00
Author
Member
Copy Link

No, ya que ni existía la tabla, se ve que alguien tenía la tarea de eliminarlo, pero se dejo esa dependencia.
Además estamos hablando del cleanFloramondo

No, ya que ni existía la tabla, se ve que alguien tenía la tarea de eliminarlo, pero se dejo esa dependencia. Además estamos hablando del cleanFloramondo
guillermo marked this conversation as resolved
guillermo requested review from carlosap 2024-04-25 05:02:20 +00:00
guillermo added 1 commit 2024-04-25 05:02:21 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
60a3ec99d0 Merge branch 'dev' into 7258-lastChangesMigrationVn2008
carlosap approved these changes 2024-04-29 17:33:11 +00:00
guillermo merged commit 80b44ccace into dev 2024-04-30 05:37:34 +00:00
guillermo deleted branch 7258-lastChangesMigrationVn2008 2024-04-30 05:37:34 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosap
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2362
No description provided.
Delete Branch "7258-lastChangesMigrationVn2008"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?