verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

feat: refs #179918 entry delete isBooked #2393

Merged
robert merged 2 commits from 179918-cleanDeleteEntry into master 2024-05-02 11:46:14 +00:00
Conversation 0 Commits 2 Files Changed 1 +2 -1
robert commented 2024-05-02 10:39:40 +00:00
Member
Copy Link
No description provided.
robert added 1 commit 2024-05-02 10:39:40 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
145a477a80 feat: refs #179918 entry delete isBooked
robert requested review from guillermo 2024-05-02 10:46:28 +00:00
guillermo requested changes 2024-05-02 11:17:37 +00:00
Dismissed
db/routines/vn/procedures/clean.sql Outdated
@ -133,2 +133,3 @@
FROM entry e
JOIN tEntryToDelete tmp ON tmp.id = e.id;
JOIN tEntryToDelete tmp ON tmp.id = e.id
WHERE e.isBooked = FALSE;
guillermo commented 2024-05-02 11:17:34 +00:00
Member
Copy Link

WHERE NOT e.isBooked;

WHERE NOT e.isBooked;
robert marked this conversation as resolved
robert added 1 commit 2024-05-02 11:33:36 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
00eae3920b feat: refs 179918 clean
robert requested review from guillermo 2024-05-02 11:36:08 +00:00
guillermo approved these changes 2024-05-02 11:41:43 +00:00
robert merged commit 9f2c3bbd0d into master 2024-05-02 11:46:14 +00:00
robert deleted branch 179918-cleanDeleteEntry 2024-05-02 11:46:14 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
guillermo
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2393
No description provided.
Delete Branch "179918-cleanDeleteEntry"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?