refactor: refs #7519 Refactor claim_ratio_routine #2394

Merged
guillermo merged 14 commits from 6701-claimRatioRoutine into dev 2024-06-21 05:05:21 +00:00
Member
No description provided.
guillermo added 1 commit 2024-05-02 12:59:29 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
3146f4f5b6
refactor: refs #6701 Refactor claim_ratio_routine
guillermo added 1 commit 2024-05-03 11:47:40 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
883f6f18a3
refactor: refs #6701 Refactor claim_ratio_routine
guillermo added 1 commit 2024-05-03 11:48:28 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
b0801f428d
Merge branch 'dev' into 6701-claimRatioRoutine
guillermo added 2 commits 2024-05-03 12:15:39 +00:00
guillermo changed title from refactor: refs #6701 Refactor claim_ratio_routine to WIP: refactor: refs #6701 Refactor claim_ratio_routine 2024-05-03 12:16:45 +00:00
guillermo added 1 commit 2024-06-03 09:38:11 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
4703ebbdf3
refactor: refs #7519 Minor change
guillermo added 2 commits 2024-06-03 09:41:13 +00:00
guillermo changed title from WIP: refactor: refs #6701 Refactor claim_ratio_routine to refactor: refs #6701 Refactor claim_ratio_routine 2024-06-03 09:41:26 +00:00
guillermo changed title from refactor: refs #6701 Refactor claim_ratio_routine to refactor: refs #7519 Refactor claim_ratio_routine 2024-06-03 09:41:38 +00:00
guillermo added 1 commit 2024-06-03 09:46:55 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
b8e95c0284
refactor: refs #7519 Minor change
guillermo added 1 commit 2024-06-13 09:14:02 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
cb056ff789
Merge branch 'dev' into 6701-claimRatioRoutine
guillermo added 1 commit 2024-06-13 11:11:54 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
cfc5e32715
feat: refs #6701 Fix error
guillermo added 1 commit 2024-06-13 11:12:25 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
961aba285e
Merge branch 'dev' into 6701-claimRatioRoutine
guillermo requested review from carlosap 2024-06-13 11:14:23 +00:00
carlosap requested changes 2024-06-14 12:13:50 +00:00
Dismissed
@ -0,0 +5,4 @@
* Añade a la tabla greuges todos los cargos necesario y
* que luego lo utilizamos para calcular el recobro.
*/
DECLARE vMonthToRefund INT DEFAULT 4;
Member

Eliminar los números

Eliminar los números
guillermo marked this conversation as resolved
@ -0,0 +35,4 @@
SELECT c.ticketCreated,
c.clientFk,
CONCAT('Claim ', c.id,' : ', s.concept),
ROUND(-1 * ((c.responsibility - 1) / 4) * s.quantity *
Member

Se utiliza varias veces, mirar hacer una columna virtual en la tabla claim

Se utiliza varias veces, mirar hacer una columna virtual en la tabla claim
Author
Member

Se utiliza únicamente solo 2 veces en el procedimiento, no creo que sea justificación para crear una columna virtual.

De todas formas se puede crear redmine para valorarlo.

Se utiliza únicamente solo 2 veces en el procedimiento, no creo que sea justificación para crear una columna virtual. De todas formas se puede crear redmine para valorarlo.
guillermo marked this conversation as resolved
@ -0,0 +86,4 @@
-- Recobros
CREATE OR REPLACE TEMPORARY TABLE tTicketList
(PRIMARY KEY (ticketFk))
Member

Añadir MEMORY?

Añadir MEMORY?
guillermo marked this conversation as resolved
@ -0,0 +97,4 @@
JOIN alertLevel al ON al.id = st.alertLevel
WHERE sc.componentFk = vDebtComponentType
AND NOT sc.isGreuge
AND t.shipped >= '2016-10-01'
Member

Eliminar y pasar a table config

Eliminar y pasar a table config
guillermo marked this conversation as resolved
@ -0,0 +101,4 @@
AND t.shipped < util.VN_CURDATE()
AND al.code = 'DELIVERED';
DELETE g.*
Member

DELETE g no es necesario g.*

DELETE g no es necesario g.*
Author
Member

Sí que lo es, si no da error.

Sí que lo es, si no da error.
guillermo marked this conversation as resolved
@ -0,0 +142,4 @@
priceIncreasing
)
SELECT c.id,
12 * cac.invoiced,
Member

12

12
Author
Member

Entiendo que se refiere a los meses que tiene un año, en ese caso hablamos que se permitia.

Entiendo que se refiere a los meses que tiene un año, en ese caso hablamos que se permitia.
guillermo marked this conversation as resolved
@ -0,0 +173,4 @@
GROUP BY clientFk
) sub ON sub.clientFk = cr.clientFk
SET cr.priceIncreasing = GREATEST(0, ROUND(IFNULL(sub.greuge, 0) /
(IFNULL(cr.yearSale, 0) * vMonthToRefund / 12 ), 3));
Member

12

12
Author
Member

Entiendo que se refiere a los meses que tiene un año, en ese caso hablamos que se permitia.

Entiendo que se refiere a los meses que tiene un año, en ese caso hablamos que se permitia.
guillermo marked this conversation as resolved
guillermo added 1 commit 2024-06-17 07:42:20 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
1d0b89ed52
refs #7519 Requested changes
guillermo requested review from carlosap 2024-06-17 07:42:34 +00:00
guillermo added 1 commit 2024-06-17 07:42:37 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
43df0ef55d
Merge branch 'dev' into 6701-claimRatioRoutine
carlosap approved these changes 2024-06-20 12:53:07 +00:00
guillermo merged commit 6874474207 into dev 2024-06-21 05:05:21 +00:00
guillermo deleted branch 6701-claimRatioRoutine 2024-06-21 05:05:21 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2394
No description provided.