verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

feat: refs #6739 transferInvoice new functionality #2412

Merged
jon merged 10 commits from 6739-transferInvoiceOut into dev 2024-05-10 04:51:42 +00:00
Conversation 0 Commits 10 Files Changed 6 +69 -26
jon commented 2024-05-06 12:53:31 +00:00
Member
Copy Link
No description provided.
jon added 1 commit 2024-05-06 12:53:32 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
4e78307a8d feat: refs #6739 transferInvoice new functionality
jon added 1 commit 2024-05-07 09:35:05 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
d4f734455d refactor: refs #6739 transferInvoice() refactor
jon added 1 commit 2024-05-07 09:36:30 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
5e96049e65 Merge branch 'dev' into 6739-transferInvoiceOut
jon requested review from jgallego 2024-05-07 09:39:49 +00:00
jgallego requested changes 2024-05-08 07:33:41 +00:00
Dismissed
modules/invoiceOut/front/descriptor-menu/index.html Outdated
@ -232,6 +233,7 @@
fields="['id','code','description']"
required="true"
ng-model="$ctrl.siiTypeInvoiceOut"
ng-init="$ctrl.siiTypeInvoiceOut = (siiTypeInvoiceOuts.length > 0 ? siiTypeInvoiceOuts[3].id : null)"
jgallego commented 2024-05-08 07:30:11 +00:00
Owner
Copy Link

no poner numeros

no poner numeros
jon marked this conversation as resolved
modules/invoiceOut/front/descriptor-menu/index.js Outdated
@ -145,0 +162,4 @@
const hasToInvoiceByAddress = clientData.hasToInvoiceByAddress;
if (this.checked && hasToInvoiceByAddress) {
if (window.confirm('El cliente destino tiene marcado facturar por consignatario, ¿desea continuar?'))
jgallego commented 2024-05-08 07:33:26 +00:00
Owner
Copy Link

usar el negado para no llamar 2 veces a la funcion

usar el negado para no llamar 2 veces a la funcion
jon marked this conversation as resolved
jon added 2 commits 2024-05-08 12:12:10 +00:00
jon added 1 commit 2024-05-08 12:30:20 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
77c2f61f47 refs #6739 move petitions
jon added 1 commit 2024-05-08 12:31:33 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
0f973baa65 Merge branch 'dev' into 6739-transferInvoiceOut
jon requested review from jgallego 2024-05-08 12:54:29 +00:00
jgallego requested changes 2024-05-09 05:35:59 +00:00
Dismissed
modules/invoiceOut/front/descriptor-menu/locale/es.yml Outdated
@ -26,1 +26,4 @@
Transferred invoice: Factura transferida
transferInvoice: Transferir factura
destinationClient: Facturar cliente destino
checkinfo: Los nuevos tickets del cliente destino, serán generados en el consignatario por defecto.
jgallego commented 2024-05-09 05:35:49 +00:00
Owner
Copy Link

esta clave checkinfo es ambigua, podria tener colisiones con otras secciones y ser de algo totalmente distinto, pon algo mas concreto si no te viene nada chatgpt

esta clave checkinfo es ambigua, podria tener colisiones con otras secciones y ser de algo totalmente distinto, pon algo mas concreto si no te viene nada chatgpt
jgallego marked this conversation as resolved
jon added 2 commits 2024-05-09 06:05:22 +00:00
jon added 1 commit 2024-05-09 06:06:43 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
b9e53df218 Merge branch 'dev' into 6739-transferInvoiceOut
jon requested review from jgallego 2024-05-09 11:19:43 +00:00
jgallego approved these changes 2024-05-09 15:38:00 +00:00
jon merged commit 6207d79244 into dev 2024-05-10 04:51:42 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2412
No description provided.
Delete Branch "6739-transferInvoiceOut"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?