verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

feat: refs #7335 Added call ticket_afterUpdate #2415

Merged
guillermo merged 7 commits from 7335-modifyCmr into dev 2024-05-08 11:54:03 +00:00
Conversation 0 Commits 7 Files Changed 2 +6 -11
guillermo commented 2024-05-07 06:07:43 +00:00
Member
Copy Link
No description provided.
guillermo added 1 commit 2024-05-07 06:07:44 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
e44568ff4b feat: refs #6585 Added call ticket_afterUpdate
guillermo added 1 commit 2024-05-07 10:36:30 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
45f7412b35 Merge branch 'dev' into 7335-modifyCmr
guillermo added 2 commits 2024-05-07 11:03:30 +00:00
guillermo requested review from jgallego 2024-05-07 12:56:40 +00:00
jgallego requested changes 2024-05-07 13:17:57 +00:00
Dismissed
db/routines/vn/procedures/ticket_doCmr.sql Outdated
@ -76,3 +70,3 @@
IF vPreviousCmrFk <> vCurrentCmrFk THEN
IF (SELECT EXISTS(SELECT * FROM tTicket)) THEN
UPDATE ticket
SET cmrFk = vCurrentCmrFk
jgallego commented 2024-05-07 13:15:52 +00:00
Owner
Copy Link

SQL Error [1054] [42S22]: Unknown column 'vCurrentCmrFk' in 'field list'

SQL Error [1054] [42S22]: Unknown column 'vCurrentCmrFk' in 'field list'
guillermo marked this conversation as resolved
db/routines/vn/triggers/ticket_afterUpdate.sql
@ -8,2 +8,4 @@
SET hasNewRoute = TRUE
WHERE ticketFk = NEW.id;
CALL ticket_doCmr(NEW.id);
jgallego commented 2024-05-07 13:17:52 +00:00
Owner
Copy Link

tal com esta el if de dalt, si es posa una ruta a null o una ruta te null y se li asigna valor, en entra en este if...valora si això es correcte.

tal com esta el if de dalt, si es posa una ruta a null o una ruta te null y se li asigna valor, en entra en este if...valora si això es correcte.
guillermo commented 2024-05-08 08:28:16 +00:00
Author
Member
Copy Link

Es correcto, ya que si es uno de los dos (NEW.id o OLD.id) es null, no queremos que entre.

Ya que el CMR se genera cuando se le cambia el estado al ticket.

Es correcto, ya que si es uno de los dos (NEW.id o OLD.id) es null, no queremos que entre. Ya que el CMR se genera cuando se le cambia el estado al ticket.
guillermo marked this conversation as resolved
guillermo added 1 commit 2024-05-08 06:47:47 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
6cde2e8170 fix: refs #6585 Requested changes
guillermo changed title from feat: refs #6585 Added call ticket_afterUpdate to feat: refs #7335 Added call ticket_afterUpdate 2024-05-08 08:28:39 +00:00
guillermo requested review from jgallego 2024-05-08 08:28:55 +00:00
guillermo added 1 commit 2024-05-08 08:29:03 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
16e7fb9662 Merge branch 'dev' into 7335-modifyCmr
jgallego approved these changes 2024-05-08 10:47:58 +00:00
guillermo added 1 commit 2024-05-08 10:55:50 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
4df13d900a Merge branch 'dev' into 7335-modifyCmr
guillermo merged commit f86d1ded72 into dev 2024-05-08 11:54:03 +00:00
guillermo deleted branch 7335-modifyCmr 2024-05-08 11:54:03 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2415
No description provided.
Delete Branch "7335-modifyCmr"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?