verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

feat: refs #3199 Added one more scope ticketTotal #2447

Merged
guillermo merged 15 commits from 3199-ticket_recalc_itemTaxCountry into dev 2024-08-21 12:32:28 +00:00
Conversation 0 Commits 15 Files Changed 1 +21 -8
guillermo commented 2024-05-14 05:52:29 +00:00
Member
Copy Link
No description provided.
guillermo added 1 commit 2024-05-14 05:52:30 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
4d7ac901c6 feat: refs #3199 Added more scopes ticket_recalcByScope
guillermo changed title from feat: refs #3199 Added more scopes ticket_recalcByScope to WIP: feat: refs #3199 Added more scopes ticket_recalcByScope 2024-05-14 05:54:03 +00:00
guillermo added 1 commit 2024-05-14 05:54:54 +00:00
guillermo added 1 commit 2024-05-14 05:55:04 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
5fe88faabd Merge branch 'dev' into 3199-ticket_recalc_itemTaxCountry
guillermo added 2 commits 2024-05-14 06:24:13 +00:00
guillermo added 1 commit 2024-05-14 06:58:48 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
2cee9c9c01 feat: refs #3199 Added one more scope ticket_recalcByScope
guillermo added 1 commit 2024-05-14 06:59:15 +00:00
guillermo changed title from WIP: feat: refs #3199 Added more scopes ticket_recalcByScope to WIP: feat: refs #3199 Added one more scope ticketTotal 2024-05-14 07:01:15 +00:00
guillermo changed title from WIP: feat: refs #3199 Added one more scope ticketTotal to feat: refs #3199 Added one more scope ticketTotal 2024-07-08 09:59:29 +00:00
guillermo added 1 commit 2024-07-08 09:59:35 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
098bda0f9c Merge branch 'dev' into 3199-ticket_recalc_itemTaxCountry
guillermo requested review from juan 2024-07-08 09:59:43 +00:00
juan requested changes 2024-07-19 06:49:46 +00:00
Dismissed
db/routines/vn/procedures/ticket_recalcByScope.sql
@ -21,0 +17,4 @@
SELECT DISTINCT t.id
FROM ticket t
JOIN sale s ON s.ticketFk = t.id
JOIN itemTaxCountry itc ON itc.itemFk = s.itemFk
juan commented 2024-07-19 06:47:23 +00:00
Owner
Copy Link

Porque se hace JOIN con itemTaxCountry si no se utiliza ninguno de los campos de la tabla?

Para filtrar por itemFk puede hacerse utilizando directamente s.itemFk

Porque se hace JOIN con `itemTaxCountry` si no se utiliza ninguno de los campos de la tabla? Para filtrar por `itemFk` puede hacerse utilizando directamente `s.itemFk`
guillermo commented 2024-07-19 07:03:30 +00:00
Author
Member
Copy Link

Porque quiero que tenga registro en la tabla itemTaxCountry, si no no tiene sentido

Porque quiero que tenga registro en la tabla `itemTaxCountry`, si no no tiene sentido
guillermo marked this conversation as resolved
db/routines/vn/procedures/ticket_recalcByScope.sql
@ -21,0 +19,4 @@
JOIN sale s ON s.ticketFk = t.id
JOIN itemTaxCountry itc ON itc.itemFk = s.itemFk
WHERE t.refFk IS NULL
AND DATE(t.shipped) > util.VN_CURDATE()
juan commented 2024-07-19 06:49:41 +00:00
Owner
Copy Link

Si se pasa la columna t.shipped por la funcion DATE no se utilizara el indice y la tabla ticket es demasiado grande como para aplicar filtros sin índice.

Ademas, el filtro no aplica, ya que en caso de recalcular totales, queremos hacerlo de todos aquellos tickets no facturados.

Si se pasa la columna `t.shipped` por la funcion `DATE` no se utilizara el indice y la tabla `ticket` es demasiado grande como para aplicar filtros sin índice. Ademas, el filtro no aplica, ya que en caso de recalcular totales, queremos hacerlo de todos aquellos tickets no facturados.
guillermo marked this conversation as resolved
guillermo added 1 commit 2024-07-19 07:09:48 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
e61210fd17 feat: #3199 Requested changes
guillermo requested review from juan 2024-07-19 07:09:51 +00:00
guillermo reviewed 2024-08-14 07:02:37 +00:00
db/routines/vn/procedures/ticket_recalcByScope.sql Outdated
@ -21,0 +22,4 @@
AND (
(vScope = 'client' AND t.clientFk = vId)
OR (vScope = 'address' AND t.addressFk = vId)
OR (vScope = 'item' AND itc.itemFk = vId)
guillermo commented 2024-08-14 07:02:37 +00:00
Author
Member
Copy Link

Juan:

Generar una tabla temporal para que solo pase por sale y itemTaxCountry cuando sea vScope = 'item'.

Juan: Generar una tabla temporal para que solo pase por sale y itemTaxCountry cuando sea vScope = 'item'.
guillermo marked this conversation as resolved
guillermo added 1 commit 2024-08-20 08:58:31 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
a995d80b46 feat: refs #3199 Requested changes
guillermo added 1 commit 2024-08-20 08:59:10 +00:00
gitea/salix/pipeline/pr-dev Build queued... Details
d0f1362f85 feat: refs #3199 Requested changes
guillermo added 1 commit 2024-08-20 08:59:45 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
1db68c08ed Merge branch 'dev' into 3199-ticket_recalc_itemTaxCountry
jgallego requested review from jgallego 2024-08-20 10:39:17 +00:00
jgallego removed review request for juan 2024-08-20 10:39:19 +00:00
jgallego dismissed juan’s review 2024-08-20 10:39:23 +00:00
Reason:

vacaciones

jgallego requested changes 2024-08-20 10:39:47 +00:00
Dismissed
db/routines/vn/procedures/ticket_recalcByScope.sql
@ -23,1 +26,3 @@
SET vDone = TRUE;
DECLARE CONTINUE HANDLER FOR NOT FOUND SET vDone = TRUE;
CREATE OR REPLACE TEMPORARY TABLE tItems
jgallego commented 2024-08-20 10:39:04 +00:00
Owner
Copy Link

pk y engine

pk y engine
guillermo marked this conversation as resolved
guillermo added 2 commits 2024-08-20 10:59:35 +00:00
jgallego approved these changes 2024-08-21 11:32:57 +00:00
guillermo added 1 commit 2024-08-21 12:28:25 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
73fedfabea Merge branch 'dev' into 3199-ticket_recalc_itemTaxCountry
guillermo merged commit 35c49b4708 into dev 2024-08-21 12:32:28 +00:00
guillermo deleted branch 3199-ticket_recalc_itemTaxCountry 2024-08-21 12:32:29 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2447
No description provided.
Delete Branch "3199-ticket_recalc_itemTaxCountry"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?