verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refs #7217 create travel_throwAWBError #2465

Merged
ivanm merged 8 commits from 7217-Unify_errorMessageAWB into dev 2024-05-27 10:34:30 +00:00
Conversation 0 Commits 8 Files Changed 5 +22 -8
ivanm commented 2024-05-16 13:37:42 +00:00
Member
Copy Link
No description provided.
ivanm added 1 commit 2024-05-16 13:37:43 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
b2db076c2f refs #7217 create travel_throwAWBError
ivanm requested review from pablone 2024-05-16 13:39:35 +00:00
ivanm changed title from refs #7217 create travel_throwAWBError to WIP: refs #7217 create travel_throwAWBError 2024-05-16 16:33:50 +00:00
guillermo requested changes 2024-05-17 05:10:20 +00:00
Dismissed
db/routines/vn/procedures/travel_throwAWBError.sql Outdated
@ -0,0 +1,14 @@
DELIMITER $$
CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`travel_throwAWBError`(vSelf INT)
guillermo commented 2024-05-17 05:10:18 +00:00
Member
Copy Link

El nombre travel_throwAWBError es incorrecto, en todo caso sería travel_throwAwbError.

Repensar el nombre, ya que throw y error hacen referencia lógica a lo mismo, yo lo dejaría en travel_throwAwb

El nombre `travel_throwAWBError` es incorrecto, en todo caso sería `travel_throwAwbError`. Repensar el nombre, ya que throw y error hacen referencia lógica a lo mismo, yo lo dejaría en `travel_throwAwb`
ivanm marked this conversation as resolved
db/routines/vn/procedures/travel_throwAWBError.sql Outdated
@ -0,0 +8,4 @@
* @param vSelf The travel id
*/
IF NOT travel_hasUniqueAwb(vSelf) THEN
CALL util.throw('The AWB is incorrect, there is a different AWB in the associated entries');
guillermo commented 2024-05-17 05:06:26 +00:00
Member
Copy Link

El msg no puede contener más de 55 caracteres.

El msg no puede contener más de 55 caracteres.
ivanm marked this conversation as resolved
ivanm added 1 commit 2024-05-17 06:17:00 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
4bf36f2655 refs #7217 Modify proc name
ivanm requested review from guillermo 2024-05-17 06:23:13 +00:00
guillermo requested changes 2024-05-17 07:08:31 +00:00
Dismissed
db/routines/vn/procedures/travel_throwAwb.sql Outdated
@ -0,0 +8,4 @@
* @param vSelf The travel id
*/
IF NOT travel_hasUniqueAwb(vSelf) THEN
CALL util.throw('The AWB is wrong; a different AWB is in the entries');
guillermo commented 2024-05-17 07:08:29 +00:00
Member
Copy Link

Por que pones un ; ??

Por que pones un ; ??
ivanm marked this conversation as resolved
ivanm added 1 commit 2024-05-17 07:53:26 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
db28bf335e refs #7217 Modify error message
ivanm changed title from WIP: refs #7217 create travel_throwAWBError to refs #7217 create travel_throwAWBError 2024-05-17 07:55:21 +00:00
ivanm added 1 commit 2024-05-17 07:55:29 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
68425bd41f Merge branch 'dev' into 7217-Unify_errorMessageAWB
ivanm requested review from guillermo 2024-05-17 07:56:44 +00:00
ivanm added 1 commit 2024-05-17 14:13:41 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
8b6844b9f0 Merge branch 'dev' into 7217-Unify_errorMessageAWB
guillermo requested changes 2024-05-24 08:03:01 +00:00
Dismissed
db/routines/vn/procedures/travel_throwAwb.sql Outdated
@ -0,0 +8,4 @@
* @param vSelf The travel id
*/
IF NOT travel_hasUniqueAwb(vSelf) THEN
CALL util.throw('The AWB is wrong. A different AWB is in the entries');
guillermo commented 2024-05-24 08:02:59 +00:00
Member
Copy Link

Creo que con A different AWB is found in the entries es suficiente, ya que si no hay redundancia.

Creo que con `A different AWB is found in the entries` es suficiente, ya que si no hay redundancia.
ivanm marked this conversation as resolved
ivanm added 1 commit 2024-05-24 08:21:47 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
7e22e19e62 refs #7217 Reduce error message
ivanm added 1 commit 2024-05-24 08:23:08 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
4d79dabb69 Merge branch 'dev' into 7217-Unify_errorMessageAWB
ivanm requested review from guillermo 2024-05-24 08:24:55 +00:00
guillermo approved these changes 2024-05-24 08:54:34 +00:00
pablone approved these changes 2024-05-27 10:32:29 +00:00
ivanm added 1 commit 2024-05-27 10:33:04 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
6222d2657b Merge branch 'dev' into 7217-Unify_errorMessageAWB
ivanm merged commit 745404e761 into dev 2024-05-27 10:34:30 +00:00
ivanm deleted branch 7217-Unify_errorMessageAWB 2024-05-27 10:34:30 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
guillermo
pablone
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2465
No description provided.
Delete Branch "7217-Unify_errorMessageAWB"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?