verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

fix: checking process.env.NODE_ENV #2492

Merged
alexm merged 5 commits from 7421-fix_checking_NODE_ENV into dev 2024-05-21 13:22:03 +00:00
Conversation 0 Commits 5 Files Changed 15 +32 -16
alexm commented 2024-05-21 11:51:20 +00:00
Member
Copy Link
No description provided.
alexm added 1 commit 2024-05-21 11:51:21 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
18bb8a4ea5 fix: checking process.env.NODE_ENV
alexm added 1 commit 2024-05-21 11:52:56 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
d884192066 fix: checking process.env.NODE_ENV
alexm added 1 commit 2024-05-21 12:03:17 +00:00
gitea/salix/pipeline/pr-master There was a failure building this commit Details
gitea/salix/pipeline/pr-dev This commit looks good Details
1f2017c272 fix: simplify
carlosap requested review from jgallego 2024-05-21 12:07:41 +00:00
jgallego approved these changes 2024-05-21 12:09:43 +00:00
carlosap requested review from juan 2024-05-21 12:21:45 +00:00
carlosap reviewed 2024-05-21 12:26:28 +00:00
modules/account/back/models/samba-config.js Outdated
@ -12,7 +13,7 @@ const UserAccountControlFlags = {
};
module.exports = Self => {
const shouldSync = process.env.NODE_ENV !== 'test';
carlosap commented 2024-05-21 12:26:27 +00:00
Member
Copy Link

Esto no estoy seguro si lo esta haciendo bien.

Esto no estoy seguro si lo esta haciendo bien.
jgallego removed review request for juan 2024-05-21 13:02:40 +00:00
alexm changed target branch from master to dev 2024-05-21 13:02:41 +00:00
alexm added 1 commit 2024-05-21 13:11:39 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
ff33c926af fix: move to boot
alexm added 1 commit 2024-05-21 13:12:32 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
28279b0782 Merge branch 'dev' into 7421-fix_checking_NODE_ENV
alexm merged commit f0d3bfba92 into dev 2024-05-21 13:22:03 +00:00
alexm deleted branch 7421-fix_checking_NODE_ENV 2024-05-21 13:22:04 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2492
No description provided.
Delete Branch "7421-fix_checking_NODE_ENV"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?