verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

feat: refs #7187 Add support for multiple PDAs per user #2496

Merged
pablone merged 2 commits from 7187-add-traducctions into test 2024-05-23 10:24:54 +00:00
Conversation 0 Commits 2 Files Changed 3 +8 -3
pablone commented 2024-05-21 17:26:13 +00:00
Member
Copy Link
No description provided.
pablone added 1 commit 2024-05-21 17:26:14 +00:00
gitea/salix/pipeline/pr-test This commit looks good Details
2142b78deb feat: refs #7187 Add support for multiple PDAs per user
pablone requested review from alexm 2024-05-21 17:26:17 +00:00
alexm reviewed 2024-05-23 10:17:50 +00:00
modules/worker/back/models/device-production-user.js Outdated
@ -5,1 +5,4 @@
return new UserError(`This PDA is already assigned to another user`);
if (err.code === 'ER_SIGNAL_EXCEPTION' && err.sqlMessage === 'You can only have one active PDA')
return new UserError(`You can only have one active PDA`);
alexm commented 2024-05-23 10:17:50 +00:00
Member
Copy Link

Tb se podria haver fet return new UserError(err.sqlMessage) per no repetir

Tb se podria haver fet `return new UserError(err.sqlMessage)` per no repetir
pablone marked this conversation as resolved
alexm approved these changes 2024-05-23 10:18:00 +00:00
pablone added 1 commit 2024-05-23 10:23:39 +00:00
gitea/salix/pipeline/pr-test This commit looks good Details
86a6211cd8 fix: refs #7187 fix duplicate
pablone merged commit a919c71369 into test 2024-05-23 10:24:54 +00:00
pablone deleted branch 7187-add-traducctions 2024-05-23 10:24:54 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2496
No description provided.
Delete Branch "7187-add-traducctions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?