verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

fix: problems in colums ticket and sale refs #7213 #2497

Merged
carlosap merged 1 commits from 7213-Problems-in-colums-ticket-and-sale into test 2024-05-23 10:53:16 +00:00
Conversation 0 Commits 1 Files Changed 6 +18 -15
carlosap commented 2024-05-22 12:52:32 +00:00
Member
Copy Link
No description provided.
carlosap added 1 commit 2024-05-22 12:52:33 +00:00
gitea/salix/pipeline/pr-test This commit looks good Details
bc6af32962 fix: problems in colums ticket and sale refs #7213
carlosap requested review from jgallego 2024-05-22 12:52:38 +00:00
jgallego requested changes 2024-05-22 13:39:14 +00:00
db/routines/vn/procedures/ticket_setProblemTooLittleItemCost.sql
@ -16,3 +16,3 @@
SELECT t.id ticketFk
FROM vn.ticket t
JOIN vn.sale s ON s.ticketFk = t.id
LEFT JOIN vn.sale s ON s.ticketFk = t.id
jgallego commented 2024-05-22 13:38:57 +00:00
Owner
Copy Link

Perque left? Si no hi ha sales...no cal mostrar res

Perque left? Si no hi ha sales...no cal mostrar res
carlosap commented 2024-05-22 14:10:09 +00:00
Author
Member
Copy Link

Sí volem que els tickets que no tinguen ventes es marque el problema a la capçalera del ticket.

Sí volem que els tickets que no tinguen ventes es marque el problema a la capçalera del ticket.
jgallego marked this conversation as resolved
carlosap requested review from jgallego 2024-05-22 14:10:14 +00:00
jgallego approved these changes 2024-05-23 05:04:42 +00:00
db/routines/vn/procedures/ticket_setProblemTooLittleItemCost.sql
@ -18,3 +18,3 @@
JOIN vn.sale s ON s.ticketFk = t.id
LEFT JOIN vn.sale s ON s.ticketFk = t.id
WHERE t.shipped >= util.midnight()
AND (s.itemFk = vItemFk OR vItemFk IS NULL)
jgallego commented 2024-05-23 05:04:32 +00:00
Owner
Copy Link

tin en compte que un ticket pot tindre varios itemFk repetits, ací se li pasa vItemFk, pero valora canviarlo per el saleFk.
De totes formes açò es un comentari la el codi es funcional.

tin en compte que un ticket pot tindre varios itemFk repetits, ací se li pasa vItemFk, pero valora canviarlo per el saleFk. De totes formes açò es un comentari la el codi es funcional.
carlosap commented 2024-05-23 10:51:05 +00:00
Author
Member
Copy Link

El objectiu del procediment es recalcular tots els ticket que tinguen un items determinat, perquer han canviat algún paramétre relacionat amb el volum i es necessari revisar si ara cumplixen les condicions de tooLittle per a ficar/llevar ixe problema del ticket

El objectiu del procediment es recalcular tots els ticket que tinguen un items determinat, perquer han canviat algún paramétre relacionat amb el volum i es necessari revisar si ara cumplixen les condicions de tooLittle per a ficar/llevar ixe problema del ticket
carlosap merged commit 8b967ee927 into test 2024-05-23 10:53:16 +00:00
carlosap deleted branch 7213-Problems-in-colums-ticket-and-sale 2024-05-23 10:53:16 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2497
No description provided.
Delete Branch "7213-Problems-in-colums-ticket-and-sale"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?