verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refactor: refs #7440 itemComparativeOptimization #2501

Merged
guillermo merged 2 commits from 7440-itemComparativeOptimization into dev 2024-05-23 08:55:58 +00:00
Conversation 0 Commits 2 Files Changed 1 +58 -59
guillermo commented 2024-05-23 07:49:30 +00:00
Member
Copy Link
No description provided.
guillermo added 2 commits 2024-05-23 07:49:30 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
bbd948c654 refs #7440 Minor change
guillermo requested review from jgallego 2024-05-23 07:51:15 +00:00
jgallego requested changes 2024-05-23 08:18:44 +00:00
Dismissed
db/routines/vn/procedures/item_comparative.sql
@ -276,2 +275,2 @@
LEFT JOIN entry e ON e.id = b.entryFk
LEFT JOIN origin o ON o.id = it.originFk
LEFT JOIN `entry` e ON e.id = b.entryFk
JOIN origin o ON o.id = it.originFk
jgallego commented 2024-05-23 08:18:30 +00:00
Owner
Copy Link

estas segur que tot te origin? es un camp obligatori?

estas segur que tot te origin? es un camp obligatori?
guillermo commented 2024-05-23 08:22:36 +00:00
Author
Member
Copy Link

Yes, ho he comprovat

Yes, ho he comprovat
guillermo marked this conversation as resolved
guillermo requested review from jgallego 2024-05-23 08:23:09 +00:00
guillermo changed title from 7440-itemComparativeOptimization to refactor: refs #7440 itemComparativeOptimization 2024-05-23 08:23:29 +00:00
jgallego approved these changes 2024-05-23 08:31:13 +00:00
guillermo merged commit 1730276844 into dev 2024-05-23 08:55:58 +00:00
guillermo deleted branch 7440-itemComparativeOptimization 2024-05-23 08:55:59 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2501
No description provided.
Delete Branch "7440-itemComparativeOptimization"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?