verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refactor: refs #7457 Added from param if not exists #2502

Merged
jgallego merged 14 commits from 7457-orderFilter into dev 2024-11-19 05:33:35 +00:00
Conversation 0 Commits 14 Files Changed 1 +11 -6
guillermo commented 2024-05-23 10:16:20 +00:00
Member
Copy Link
No description provided.
guillermo added 1 commit 2024-05-23 10:16:21 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
33f1ed360b refactor: refs #7457 Added from param if not exists
guillermo changed title from refactor: refs #7457 Added from param if not exists to WIP: refactor: refs #7457 Added from param if not exists 2024-05-23 11:56:37 +00:00
pablone added 1 commit 2024-10-17 06:19:57 +00:00
pablone added 1 commit 2024-10-17 06:35:30 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
a35c10adab fix: refs #7457 error on empty from param and add translate
pablone added 1 commit 2024-10-17 06:40:31 +00:00
pablone added 1 commit 2024-10-24 04:36:15 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
838dd9e1b4 Merge branch 'dev' into 7457-orderFilter
pablone changed title from WIP: refactor: refs #7457 Added from param if not exists to refactor: refs #7457 Added from param if not exists 2024-10-24 04:36:54 +00:00
pablone requested review from jgallego 2024-10-24 04:38:11 +00:00
jgallego requested changes 2024-10-24 06:11:45 +00:00
Dismissed
modules/order/back/methods/order/filter.js
@ -198,7 +201,7 @@ module.exports = Self => {
`);
jgallego commented 2024-10-24 06:10:28 +00:00
Owner
Copy Link

el refactor per a que encara que no poses fecha vaja rapid gracies al limit de salix, he canviat la descripció de la tarea.

el refactor per a que encara que no poses fecha vaja rapid gracies al limit de salix, he canviat la descripció de la tarea.
pablone commented 2024-11-11 06:35:39 +00:00
Member
Copy Link

En este cas no aplica perque te que calcular tota la llista per a fer el limit,
En una consulta a una taula simple si que funciona

En este cas no aplica perque te que calcular tota la llista per a fer el limit, En una consulta a una taula simple si que funciona
pablone marked this conversation as resolved
pablone added 1 commit 2024-11-11 06:34:34 +00:00
pablone requested review from jgallego 2024-11-11 06:35:56 +00:00
jgallego requested changes 2024-11-11 06:59:39 +00:00
Dismissed
modules/order/back/methods/order/filter.js
@ -23,3 +23,3 @@
arg: 'from',
type: 'date',
description: 'The from date'
description: 'The from date',
jgallego commented 2024-11-11 06:59:36 +00:00
Owner
Copy Link

se quedà que se deu de poder consultar tots els tickets d'un client. Que havent un limit no deuria anar lento. La solució no es obligar a pasar parametros.

se quedà que se deu de poder consultar tots els tickets d'un client. Que havent un limit no deuria anar lento. La solució no es obligar a pasar parametros.
pablone marked this conversation as resolved
pablone added 1 commit 2024-11-14 14:50:33 +00:00
pablone requested review from jgallego 2024-11-14 14:51:46 +00:00
jgallego approved these changes 2024-11-14 15:24:44 +00:00
Dismissed
pablone added 1 commit 2024-11-15 06:17:07 +00:00
pablone requested review from jgallego 2024-11-15 06:20:33 +00:00
pablone added 1 commit 2024-11-15 11:56:55 +00:00
pablone scheduled this pull request to auto merge when all checks succeed 2024-11-18 05:20:36 +00:00
jgallego approved these changes 2024-11-18 08:21:37 +00:00
pablone added 1 commit 2024-11-18 10:05:31 +00:00
pablone added 1 commit 2024-11-19 05:12:20 +00:00
pablone scheduled this pull request to auto merge when all checks succeed 2024-11-19 05:13:41 +00:00
pablone canceled auto merging this pull request when all checks succeed 2024-11-19 05:13:46 +00:00
pablone added 1 commit 2024-11-19 05:30:46 +00:00
jgallego merged commit 7a9bcf11e2 into dev 2024-11-19 05:33:35 +00:00
jgallego deleted branch 7457-orderFilter 2024-11-19 05:33:35 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2502
No description provided.
Delete Branch "7457-orderFilter"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?