verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 59 Releases Wiki Activity

refactor: refs #7457 Added from param if not exists #2502

Merged
jgallego merged 14 commits from 7457-orderFilter into dev 2024-11-19 05:33:35 +00:00
Conversation 0 Commits 14 Files Changed 1 -2
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit fc61f7e4ab - Show all commits

2
modules/order/back/methods/order/filter.js
View File

@ -201,7 +201,6 @@ module.exports = Self => {
`); `);
pablone marked this conversation as resolved
jgallego commented 2024-10-24 06:10:28 +00:00
Review
Copy Link

el refactor per a que encara que no poses fecha vaja rapid gracies al limit de salix, he canviat la descripció de la tarea.

el refactor per a que encara que no poses fecha vaja rapid gracies al limit de salix, he canviat la descripció de la tarea.
pablone commented 2024-11-11 06:35:39 +00:00
Review
Copy Link

En este cas no aplica perque te que calcular tota la llista per a fer el limit,
En una consulta a una taula simple si que funciona

En este cas no aplica perque te que calcular tota la llista per a fer el limit, En una consulta a una taula simple si que funciona
stmt.merge(conn.makeWhere(filter.where)); stmt.merge(conn.makeWhere(filter.where));
stmt.merge(`GROUP BY o.id`);
stmt.merge(conn.makePagination(filter)); stmt.merge(conn.makePagination(filter));
stmts.push(stmt); stmts.push(stmt);
stmts.push(`SET SESSION optimizer_search_depth = @_optimizer_search_depth`); stmts.push(`SET SESSION optimizer_search_depth = @_optimizer_search_depth`);
@ -214,7 +213,6 @@ module.exports = Self => {
const sql = ParameterizedSQL.join(stmts, ';'); const sql = ParameterizedSQL.join(stmts, ';');
const result = await conn.executeStmt(sql, myOptions); const result = await conn.executeStmt(sql, myOptions);
return result[ordersIndex]; return result[ordersIndex];
}; };
}; };