verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

feat: refs #7438 Added volume to item_valuateInventory #2505

Merged
guillermo merged 2 commits from 7438-item_ValuateInventory into dev 2024-05-24 09:30:55 +00:00
Conversation 0 Commits 2 Files Changed 1 +43 -60
guillermo commented 2024-05-23 12:26:24 +00:00
Member
Copy Link
No description provided.
guillermo added 1 commit 2024-05-23 12:26:24 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
35ce259e5a feat: refs #7438 Added volume to item_valuateInventory
guillermo requested review from carlosap 2024-05-23 12:27:12 +00:00
carlosap requested changes 2024-05-23 15:06:13 +00:00
Dismissed
db/routines/vn/procedures/item_ValuateInventory.sql Outdated
@ -194,3 +197,2 @@
DELETE FROM tInventory
WHERE quantity IS NULL OR NOT quantity;
DELETE FROM tInventory WHERE quantity IS NULL OR NOT quantity;
carlosap commented 2024-05-23 14:58:48 +00:00
Member
Copy Link

es pot fer abans del UPDATE

es pot fer abans del UPDATE
guillermo marked this conversation as resolved
carlosap requested changes 2024-05-23 15:08:05 +00:00
Dismissed
db/routines/vn/procedures/item_ValuateInventory.sql Outdated
@ -229,3 +200,1 @@
WHERE wh.valuatedInventory
AND i.total > 0;
END IF;
UPDATE tInventory i
carlosap commented 2024-05-23 15:07:27 +00:00
Member
Copy Link

es pot juntar en el UPDATE que hi ha dalt, ficant un LEFT JOIN i fer-ho tot en el mateix UPDATE

es pot juntar en el UPDATE que hi ha dalt, ficant un LEFT JOIN i fer-ho tot en el mateix UPDATE
guillermo marked this conversation as resolved
guillermo added 1 commit 2024-05-24 05:20:30 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
2fe279ed47 feat: refs #7438 Requested changes and little changes
guillermo requested review from carlosap 2024-05-24 05:20:51 +00:00
carlosap approved these changes 2024-05-24 09:14:35 +00:00
guillermo merged commit 2c87730dba into dev 2024-05-24 09:30:55 +00:00
guillermo deleted branch 7438-item_ValuateInventory 2024-05-24 09:30:55 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosap
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2505
No description provided.
Delete Branch "7438-item_ValuateInventory"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?