verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

feat: refs #7203 remove numbres alertLevel #2546

Merged
jgallego merged 2 commits from 7203-alertLevel into dev 2024-06-06 09:48:30 +00:00
Conversation 0 Commits 2 Files Changed 16 +93 -147
jgallego commented 2024-06-05 06:07:44 +00:00
Owner
Copy Link
No description provided.
jgallego added 1 commit 2024-06-05 06:07:45 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
130d2b6b47 feat: refs #7203 remove numbres alertLevel
jgallego requested review from carlosap 2024-06-05 06:07:51 +00:00
carlosap requested changes 2024-06-05 06:56:38 +00:00
Dismissed
db/.pullinfo.json
@ -10,3 +10,3 @@
"vn": {
"view": {
"expeditionPallet_Print": "06613719475fcdba8309607c38cc78efc2e348cca7bc96b48dc3ae3c12426f54"
"expeditionPallet_Print": "ced2b84a114fcb99fce05f0c34f4fc03f3fa387bef92621be1bc306608a84345"
carlosap commented 2024-06-05 06:56:34 +00:00
Member
Copy Link

descartar?

descartar?
db/routines/vn/procedures/ticketParking_findSkipped.sql
@ -45,1 +45,3 @@
WHERE (s.alertLevel < 2
JOIN vn.alertLevel alPacked ON alPacked.code = 'PACKED'
JOIN vn.alertLevel alOnPreparation ON alOnPreparation.code = 'ON_PREPARATION'
WHERE (s.alertLevel < alPacked.id
carlosap commented 2024-06-05 06:49:58 +00:00
Member
Copy Link

tabulación

tabulación
db/routines/vn/procedures/ticketParking_findSkipped.sql
@ -46,4 +48,4 @@
AND tp.parkingFk = vParkingFk
AND sc.isPackagingArea
AND (
( IFNULL(tc.collectionFk,-1) != IFNULL(@vCollectionFk,0) AND tp.created < vParked )
carlosap commented 2024-06-05 06:50:28 +00:00
Member
Copy Link

los espacios y tabulación no son correctos

los espacios y tabulación no son correctos
jgallego commented 2024-06-05 10:41:47 +00:00
Author
Owner
Copy Link

les parts d'ixe proc que no he tocat les he deixat com estaven

les parts d'ixe proc que no he tocat les he deixat com estaven
jgallego marked this conversation as resolved
db/routines/vn/procedures/ticketParking_findSkipped.sql
@ -52,2 +53,3 @@
( tc.collectionFk = vCollectionFk
AND (LEFT(tc.wagon,1) < LEFT(vWagon,1)
OR (LEFT(tc.wagon,1) = LEFT(vWagon,1) AND LEFT(tc.level,1) < LEFT(vLevel,1)))
OR (LEFT(tc.wagon,1) = LEFT(vWagon,1) AND LEFT(tc.level,1) < LEFT(vLevel,1)))
carlosap commented 2024-06-05 06:49:55 +00:00
Member
Copy Link

solo se utilizan aquí vWagon y vLevel, seria más correcto trasladar a la declaración el LEFT de los campos y no hacer uso de la función en la consulta?

solo se utilizan aquí vWagon y vLevel, seria más correcto trasladar a la declaración el LEFT de los campos y no hacer uso de la función en la consulta?
jgallego marked this conversation as resolved
db/routines/vn/triggers/expedition_beforeInsert.sql Outdated
@ -15,3 +14,1 @@
SELECT IFNULL(MAX(counter),0) +1 INTO intcounter
FROM expedition e
INNER JOIN ticket t1 ON e.ticketFk = t1.id
SELECT IFNULL(MAX(counter),0) + 1 INTO intcounter
carlosap commented 2024-06-05 06:52:25 +00:00
Member
Copy Link

vIntCounter

vIntCounter
jgallego added 1 commit 2024-06-05 10:43:09 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
1fa22e71a9 feat: refs #7203 nombre variables
jgallego requested review from carlosap 2024-06-05 11:58:20 +00:00
carlosap approved these changes 2024-06-05 12:08:54 +00:00
jgallego merged commit e77bc87a2a into dev 2024-06-06 09:48:30 +00:00
jgallego deleted branch 7203-alertLevel 2024-06-06 09:48:30 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosap
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2546
No description provided.
Delete Branch "7203-alertLevel"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?