verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

7276_expeditionScanned #2559

Merged
sergiodt merged 4 commits from 7276_expeditionScanned into dev 2024-06-10 06:36:51 +00:00
Conversation 1 Commits 4 Files Changed 4 +23 -8
sergiodt commented 2024-06-07 07:20:45 +00:00
Member
Copy Link
No description provided.
sergiodt added 2 commits 2024-06-07 07:20:46 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
7c0fa6dbb9 feat isScannedExpedition refs #7276
sergiodt requested review from jgallego 2024-06-07 07:20:54 +00:00
jgallego requested changes 2024-06-07 08:32:18 +00:00
Dismissed
db/routines/vn/procedures/expedition_getFromRoute.sql Outdated
@ -33,6 +34,11 @@ BEGIN
GROUP BY sub.ticketFk
) sub2 ON sub2.ticketFk = t.id
LEFT JOIN expeditionStateType est ON est.id = e.stateTypeFk
LEFT JOIN (SELECT es.expeditionFk, isScanned
jgallego commented 2024-06-07 08:32:16 +00:00
Owner
Copy Link

asegurat perque crec que no cal que anides 2, traus el max, i en la general ja pots gastarla

asegurat perque crec que no cal que anides 2, traus el max, i en la general ja pots gastarla
sergiodt commented 2024-06-10 05:30:59 +00:00
Author
Member
Copy Link

Modificat

Modificat
jgallego marked this conversation as resolved
jgallego added 1 commit 2024-06-07 13:44:28 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
f82f452423 Merge branch 'dev' into 7276_expeditionScanned
sergiodt added 1 commit 2024-06-10 05:30:43 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
4cf5c0775c feat isScannedExpedition refs #7276
sergiodt requested review from jgallego 2024-06-10 05:31:26 +00:00
jgallego approved these changes 2024-06-10 05:48:16 +00:00
jgallego left a comment
Owner
Copy Link

el nom es redundant, amb add seria suficient, pero a mes, si lo únic que fa es insertar, valora eliminarlo si es pot i gastar el natiu.

el nom es redundant, amb add seria suficient, pero a mes, si lo únic que fa es insertar, valora eliminarlo si es pot i gastar el natiu.
sergiodt commented 2024-06-10 06:36:43 +00:00
Author
Member
Copy Link

Creat redmine per fer refactor; https://redmine.verdnatura.es/issues/7561

Creat redmine per fer refactor; https://redmine.verdnatura.es/issues/7561
sergiodt merged commit 391ec435ac into dev 2024-06-10 06:36:51 +00:00
sergiodt deleted branch 7276_expeditionScanned 2024-06-10 06:36:51 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2559
No description provided.
Delete Branch "7276_expeditionScanned"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?