verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

6964-hasItemOlder #2560

Merged
sergiodt merged 9 commits from 6964-hasItemOlder into test 2024-06-18 14:27:08 +00:00
Conversation 1 Commits 9 Files Changed 8 +139 -112
sergiodt commented 2024-06-07 14:31:48 +00:00
Member
Copy Link
No description provided.
sergiodt added 4 commits 2024-06-07 14:31:49 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
cac1278c08 feat hsItemOlder refs $6964
sergiodt requested review from carlosap 2024-06-07 14:32:42 +00:00
carlosap requested changes 2024-06-17 16:28:30 +00:00
Dismissed
modules/item/back/methods/item-shelving/getListItemNewer.js
@ -0,0 +46,4 @@
JOIN vn.shelving sh ON sh.code = is2.shelvingFk
JOIN vn.parking p ON p.id = sh.parkingFk
JOIN vn.sector s ON s.id = p.sectorFk
WHERE is2.shelvingFk = ? AND s.code = "NAVE ALGEMESI"
carlosap commented 2024-06-17 16:27:04 +00:00
Member
Copy Link

Pasar a una config

Pasar a una config
modules/item/back/methods/item-shelving/getListItemNewer.js
@ -0,0 +54,4 @@
JOIN vn.parking p ON p.id = sh.parkingFk
JOIN vn.sector s ON s.id = p.sectorFk
WHERE is2.shelvingFk <> ?
AND s.code = "NAVE ALGEMESI")
carlosap commented 2024-06-17 16:27:06 +00:00
Member
Copy Link

Pasar a una config

Pasar a una config
sergiodt commented 2024-06-17 17:51:29 +00:00
Author
Member
Copy Link

Posat els casos en productionConfig

Posat els casos en productionConfig
carlosap requested review from alexm 2024-06-17 16:28:36 +00:00
sergiodt added 1 commit 2024-06-17 17:12:12 +00:00
sergiodt added 1 commit 2024-06-17 17:51:04 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
eedcdb54fa feat hasItemOlder refs#6964
sergiodt requested review from carlosap 2024-06-17 17:51:08 +00:00
alexm reviewed 2024-06-18 05:48:18 +00:00
modules/item/back/methods/item-shelving/getListItemNewer.js Outdated
@ -0,0 +17,4 @@
},
],
returns: {
type: 'Object',
alexm commented 2024-06-18 05:48:18 +00:00
Member
Copy Link

Return array

Return array
alexm requested changes 2024-06-18 05:49:31 +00:00
Dismissed
modules/item/back/methods/item-shelving/getListItemNewer.js Outdated
@ -0,0 +64,4 @@
JOIN vn.productionConfig pc
WHERE ti.created > tis.created + INTERVAL pc.itemOlderReviewHours HOUR;`,
[shelvingFk, shelvingFk], myOptions);
return result;
alexm commented 2024-06-18 05:48:48 +00:00
Member
Copy Link

Si no hi ha resultats de per si ja torna array vuit, no cal ficar el if else

const [isParkingToReview] = await Self.rawSql(`
    SELECT COUNT(p.id) parkingToReview
    FROM vn.parking p 
        JOIN vn.sector s ON s.id = p.sectorFk
        JOIN vn.productionConfig pc
    WHERE p.code = ? AND s.code = pc.sectorToCode;`,
[parking], myOptions);

if (isParkingToReview['parkingToReview'] < 1) return []
Si no hi ha resultats de per si ja torna array vuit, no cal ficar el if else ``` const [isParkingToReview] = await Self.rawSql(` SELECT COUNT(p.id) parkingToReview FROM vn.parking p JOIN vn.sector s ON s.id = p.sectorFk JOIN vn.productionConfig pc WHERE p.code = ? AND s.code = pc.sectorToCode;`, [parking], myOptions); if (isParkingToReview['parkingToReview'] < 1) return [] ```
modules/item/back/methods/item-shelving/specs/getListItemNewer.spec.js Outdated
@ -0,0 +2,4 @@
const {models} = require('vn-loopback/server/server');
describe('itemShelving getListItemNewer()', () => {
fit('should return true because there is an older item', async() => {
alexm commented 2024-06-18 05:48:58 +00:00
Member
Copy Link

quitar fit

quitar fit
sergiodt added 1 commit 2024-06-18 06:24:25 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
46cd20a1fd feat hasItemOlder refs#6964
sergiodt added 1 commit 2024-06-18 08:08:49 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
gitea/salix/pipeline/pr-test There was a failure building this commit Details
239814e6b4 feat hasItemOlder refs#6964
sergiodt requested review from alexm 2024-06-18 10:25:04 +00:00
carlosap approved these changes 2024-06-18 11:47:20 +00:00
alexm approved these changes 2024-06-18 13:02:17 +00:00
alexm changed target branch from dev to test 2024-06-18 13:02:53 +00:00
alexm commented 2024-06-18 13:03:17 +00:00
Member
Copy Link

Fusionar sin actualizar

**Fusionar sin actualizar**
sergiodt added 1 commit 2024-06-18 14:20:59 +00:00
gitea/salix/pipeline/pr-test This commit looks good Details
5694d9a9fe Merge branch 'test' into 6964-hasItemOlder
sergiodt merged commit 16d50ca2e5 into test 2024-06-18 14:27:08 +00:00
sergiodt deleted branch 6964-hasItemOlder 2024-06-18 14:27:08 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosap
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2560
No description provided.
Delete Branch "6964-hasItemOlder"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?