verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

#6238 add travelKgPercentage table and model #2590

Merged
jorgep merged 3 commits from 6238-addPercentage into dev 2024-06-18 08:41:30 +00:00
Conversation 0 Commits 3 Files Changed 4 +55 -2
jorgep commented 2024-06-14 12:25:53 +00:00
Member
Copy Link
No description provided.
jorgep added 1 commit 2024-06-14 12:25:54 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
202884fdce feat: refs #6238 add travelKgPercentage table and model
jorgep changed title from WIP: #6238 add travelKgPercentage table and model to #6238 add travelKgPercentage table and model 2024-06-14 12:53:35 +00:00
jorgep added the
CR / Tests passed
 label 2024-06-14 13:37:38 +00:00
jorgep requested review from jgallego 2024-06-14 13:37:45 +00:00
jgallego requested changes 2024-06-17 10:37:29 +00:00
Dismissed
modules/travel/back/methods/travel/extraCommunityFilter.js Outdated
@ -140,2 +140,3 @@
) as DECIMAL(10,0)
) as volumeKg
) as volumeKg,
ROUND(GREATEST(
jgallego commented 2024-06-17 10:36:13 +00:00
Owner
Copy Link

si pones un cast a int no necesitas un round y al contrario

si pones un cast a int no necesitas un round y al contrario
jorgep marked this conversation as resolved
jorgep added 1 commit 2024-06-18 07:55:40 +00:00
jorgep added 1 commit 2024-06-18 08:04:26 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
3070d1ef01 refactor: refs #6238 drop useless round
jorgep requested review from jgallego 2024-06-18 08:04:33 +00:00
jgallego approved these changes 2024-06-18 08:37:19 +00:00
jgallego left a comment
Owner
Copy Link

el cast lo dejamos temporalmente por retrocompatibilidad con access pero a salix no creo que le haga falta

el cast lo dejamos temporalmente por retrocompatibilidad con access pero a salix no creo que le haga falta
👍 1
jorgep merged commit 0bf0c6ce8c into dev 2024-06-18 08:41:30 +00:00
jorgep deleted branch 6238-addPercentage 2024-06-18 08:41:30 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2590
No description provided.
Delete Branch "6238-addPercentage"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?