verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

6868_createLogin #2598

Merged
sergiodt merged 20 commits from 6868_createLogin into dev 2024-09-13 09:43:32 +00:00
Conversation 0 Commits 20 Files Changed 5 +138 -1
sergiodt commented 2024-06-17 11:58:47 +00:00
Member
Copy Link
No description provided.
sergiodt added 6 commits 2024-06-17 11:58:48 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
9d5d62afaf feat newLogin refs #6868
sergiodt added 2 commits 2024-06-17 14:53:14 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
c6da9e72e0 feat newLogin refs #6868
sergiodt added 2 commits 2024-07-16 06:19:23 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
ae6963c26d feat handleUser refs #6868
sergiodt added 1 commit 2024-07-16 08:14:31 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
144cf20e71 feat handleUser refs #6868
sergiodt added 1 commit 2024-07-16 15:08:46 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
7870416860 feat handleUser refs #6868
sergiodt added 1 commit 2024-07-16 15:20:47 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
a82df8e2a2 feat handleUser refs #6868
jgallego requested changes 2024-08-28 11:16:55 +00:00
Dismissed
modules/account/back/methods/account/handle-user.js Outdated
@ -0,0 +1,114 @@
jgallego commented 2024-08-28 11:14:57 +00:00
Owner
Copy Link

El esquma/modulo account no tiene que tener dependencias de vn, Mover esta funcionalidad a algún modelo más oportuno tipo device o otro..

El esquma/modulo account no tiene que tener dependencias de vn, Mover esta funcionalidad a algún modelo más oportuno tipo device o otro..
sergiodt added 1 commit 2024-09-03 14:51:10 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
36cf6b1aee feat: refs #6868 refs# 6868 handleUser
sergiodt added 2 commits 2024-09-11 06:05:37 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
b492a1e6a8 feat: refs #6868 refs# 6868 handleUser
jgallego requested changes 2024-09-11 07:49:37 +00:00
Dismissed
modules/worker/back/methods/device/handle-user.js
@ -0,0 +103,4 @@
const getVersion = await models.MobileAppVersionControl.getVersion(ctx, nameApp);
const combinedResult = {
...getDataOperator.__data,
jgallego commented 2024-09-11 07:49:10 +00:00
Owner
Copy Link

acceder a propiedades como __data directamente no es una buena práctica en general, ya que estás accediendo a un atributo privado de la instancia del modelo. Esto rompe el encapsulamiento y puede hacer que el código sea frágil si alguna vez se cambia la implementación del modelo.

prova:

const combinedResult = {
    ...getDataOperator.toObject(),
    ...getDataUser.toObject(),
    ...getVersion,
    message: vMessage,
    serialNumber,
};
acceder a propiedades como __data directamente no es una buena práctica en general, ya que estás accediendo a un atributo privado de la instancia del modelo. Esto rompe el encapsulamiento y puede hacer que el código sea frágil si alguna vez se cambia la implementación del modelo. prova: ``` const combinedResult = { ...getDataOperator.toObject(), ...getDataUser.toObject(), ...getVersion, message: vMessage, serialNumber, }; ```
sergiodt commented 2024-09-13 05:12:48 +00:00
Author
Member
Copy Link

Modificat

Modificat
sergiodt added 3 commits 2024-09-13 05:02:44 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
2d4e667009 feat: refs #6868 refs# 6868 handleUser
sergiodt added 1 commit 2024-09-13 05:10:58 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
e80fe1d0dc feat: refs #6868 refs# 6868 handleUser
sergiodt requested review from jgallego 2024-09-13 05:13:17 +00:00
jgallego approved these changes 2024-09-13 07:36:04 +00:00
sergiodt merged commit 11193bebe6 into dev 2024-09-13 09:43:32 +00:00
sergiodt deleted branch 6868_createLogin 2024-09-13 09:43:32 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2598
No description provided.
Delete Branch "6868_createLogin"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?