verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

feat: Turn issues into calculated columns refs#7213 #2646

Merged
carlosap merged 3 commits from 7213-problemas-columnas into dev 2024-07-15 10:55:07 +00:00
Conversation 0 Commits 3 Files Changed 16 +245 -144
carlosap commented 2024-06-27 11:04:59 +00:00
Member
Copy Link
No description provided.
carlosap added 1 commit 2024-06-27 11:04:59 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
cbd46330b3 feat: Turn issues into calculated columns refs#7213
carlosap requested review from jgallego 2024-06-27 11:05:29 +00:00
jgallego requested changes 2024-06-28 05:47:14 +00:00
Dismissed
db/routines/vn/procedures/ticket_setProblemTaxDataChecked.sql
@ -14,1 +14,3 @@
SELECT t.id ticketFk, IF(c.isTaxDataChecked, FALSE, TRUE) hasProblem
SELECT t.id ticketFk,
IF(c.isTaxDataChecked, FALSE, TRUE) hasProblem,
ticket_isProblemCalcNeeded(t.id) isProblemCalcNeeded
jgallego commented 2024-06-28 05:47:11 +00:00
Owner
Copy Link

si posem ticket_isProblemCalcNeeded en el WHERE ens evitem tant la insercio en la taula temporal, com la posterior eliminació en el procediment, y la columna isProblemCalcNeeded ja no seria necesaria, simplement el fet d'estar la linea es que hi ha que calcular-ho.

si posem ticket_isProblemCalcNeeded en el WHERE ens evitem tant la insercio en la taula temporal, com la posterior eliminació en el procediment, y la columna isProblemCalcNeeded ja no seria necesaria, simplement el fet d'estar la linea es que hi ha que calcular-ho.
carlosap commented 2024-07-15 09:54:28 +00:00
Author
Member
Copy Link

es tenen que posar a NULL

es tenen que posar a NULL
carlosap added 1 commit 2024-07-12 14:47:31 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
49183c79f1 feat: Turn issues into calculated columns refs#7213
carlosap added 1 commit 2024-07-15 09:53:01 +00:00
carlosap requested review from jgallego 2024-07-15 09:54:55 +00:00
jgallego approved these changes 2024-07-15 10:23:16 +00:00
carlosap merged commit ac58b7a9e9 into dev 2024-07-15 10:55:07 +00:00
carlosap deleted branch 7213-problemas-columnas 2024-07-15 10:55:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2646
No description provided.
Delete Branch "7213-problemas-columnas"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?