verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 67 Releases Wiki Activity

feat(salix): #7671 define isDestiny field in model #2681

Merged
jsegarra merged 14 commits from 7671_dense_itemFixedPrices into dev 2024-09-09 12:17:57 +00:00
Conversation 0 Commits 14 Files Changed 2 +8 -1
jsegarra commented 2024-07-04 15:25:26 +00:00
Member
Copy Link

verdnatura/salix-front#527

https://gitea.verdnatura.es/verdnatura/salix-front/pulls/527
jsegarra added 1 commit 2024-07-04 15:25:26 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
2064107897 feat(salix): #7671 define isDestiny field in model
jsegarra added 3 commits 2024-07-11 22:24:30 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
9c5f38648a feat(ssalix): refs #7671 #7671 checkDates to present
jsegarra added 1 commit 2024-07-16 07:22:33 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
9206826135 Merge branch 'dev' into 7671_dense_itemFixedPrices
jsegarra added 1 commit 2024-07-16 07:23:41 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
c5cb4d84f1 Merge branch 'dev' into 7671_dense_itemFixedPrices
jsegarra added 1 commit 2024-07-18 13:21:25 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
304405a8a3 Merge branch 'dev' into 7671_dense_itemFixedPrices
jsegarra requested review from jgallego 2024-09-07 21:22:23 +00:00
jsegarra added 3 commits 2024-09-08 10:50:36 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
5c4a30f2f9 perf: refs #7671 improve showBadDates
jgallego requested changes 2024-09-09 05:44:07 +00:00
Dismissed
modules/item/back/methods/fixed-price/filter.js Outdated
@ -186,2 +187,2 @@
stmt.merge(conn.makeSuffix(filter));
if (ctx.req.query.showBadDates === 'true') {
stmt.merge({
jgallego commented 2024-09-09 05:44:00 +00:00
Owner
Copy Link

si aqui lo pones en el objeto filter.where, luego solo tienes que hacer stmt.merge(conn.makeWhere(filter.where));
ademas conctatenar sql no suele ser buena opcion

si aqui lo pones en el objeto filter.where, luego solo tienes que hacer stmt.merge(conn.makeWhere(filter.where)); ademas conctatenar sql no suele ser buena opcion
jsegarra added 2 commits 2024-09-09 07:58:15 +00:00
jsegarra requested review from jgallego 2024-09-09 07:58:54 +00:00
jsegarra added 1 commit 2024-09-09 08:07:10 +00:00
jgallego approved these changes 2024-09-09 12:15:54 +00:00
jsegarra added 1 commit 2024-09-09 12:16:17 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
03d4427bcd Merge branch 'dev' into 7671_dense_itemFixedPrices
jsegarra merged commit 1a0fb2fecd into dev 2024-09-09 12:17:57 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2681
No description provided.
Delete Branch "7671_dense_itemFixedPrices"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?