verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refactor: refs #7580 Fix and improvement #2700

Merged
guillermo merged 5 commits from 7580-setParkingfIX into dev 2024-07-12 07:34:46 +00:00
Conversation 0 Commits 5 Files Changed 5 +82 -62
guillermo commented 2024-07-08 11:17:37 +00:00
Member
Copy Link
No description provided.
guillermo added 1 commit 2024-07-08 11:17:37 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
f57ab72482 refactor: refs #7580 Fix and improvement
guillermo added 1 commit 2024-07-08 11:22:13 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
73b43aa254 refactor: refs #7580 Fixes
guillermo requested review from carlosap 2024-07-08 11:23:11 +00:00
carlosap requested changes 2024-07-10 08:15:29 +00:00
Dismissed
db/routines/vn/procedures/setParking.sql Outdated
@ -61,1 +45,4 @@
CALL shelving_setParking(vParam, vParkingFk);
END IF;
COMMIT;
carlosap commented 2024-07-10 08:15:22 +00:00
Member
Copy Link

No hay START TRANSACTION

No hay START TRANSACTION
guillermo marked this conversation as resolved
guillermo added 1 commit 2024-07-10 09:32:47 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
3c975aa9c4 refactor: refs #7580 Requested changes
guillermo requested review from carlosap 2024-07-10 09:32:58 +00:00
carlosap requested changes 2024-07-11 12:44:44 +00:00
Dismissed
db/routines/vn/procedures/setParking.sql Outdated
@ -58,3 +45,3 @@
ELSE
-- Por descarte, se considera una matrícula
CALL vn.shelving_setParking(vParam, vParkingFk);
CALL shelving_setParking(vParam, vParkingFk);
carlosap commented 2024-07-11 12:44:40 +00:00
Member
Copy Link

Para que se quede mejor el procedimiento, como ya lo estamos refactorizando en el ELSE pondríamos un THROW y la opción del shelving haríamos lo mismo que en las anteriores, comprobar con la SELECT si existe antes de llamarlo

Para que se quede mejor el procedimiento, como ya lo estamos refactorizando en el ELSE pondríamos un THROW y la opción del shelving haríamos lo mismo que en las anteriores, comprobar con la SELECT si existe antes de llamarlo
guillermo marked this conversation as resolved
guillermo added 1 commit 2024-07-11 12:50:28 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
6702ff8616 feat: refs #7580 Requested changes
guillermo requested review from carlosap 2024-07-11 12:50:46 +00:00
guillermo added 1 commit 2024-07-11 12:50:47 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
96a157d2f7 Merge branch 'dev' into 7580-setParkingfIX
carlosap approved these changes 2024-07-12 07:11:11 +00:00
guillermo merged commit 5ed8b33cef into dev 2024-07-12 07:34:46 +00:00
guillermo deleted branch 7580-setParkingfIX 2024-07-12 07:34:46 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosap
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2700
No description provided.
Delete Branch "7580-setParkingfIX"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?