verdnatura/salix
verdnatura
/
salix
3
5
Fork 0
Code Issues Pull Requests 62 Releases Wiki Activity

refactor: refs #7580 Fix and improvement #2700

Merged
guillermo merged 5 commits from 7580-setParkingfIX into dev 2024-07-12 07:34:46 +00:00
Conversation 0 Commits 5 Files Changed 5 +4 -3
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 6702ff8616 - Show all commits

7
db/routines/vn/procedures/setParking.sql
View File

@ -34,17 +34,18 @@ BEGIN
IF vParam REGEXP '^[0-9]+$' THEN IF vParam REGEXP '^[0-9]+$' THEN
SET vLastWeek = util.VN_CURDATE() - INTERVAL 1 WEEK; SET vLastWeek = util.VN_CURDATE() - INTERVAL 1 WEEK;
-- Comprobamos si es una prep. previa, ticket o colección -- Comprobamos si es una prep. previa, ticket, colección o shelving
IF (SELECT TRUE FROM saleGroup WHERE id = vParam) THEN IF (SELECT TRUE FROM saleGroup WHERE id = vParam) THEN
CALL saleGroup_setParking(vParam, vParkingFk); CALL saleGroup_setParking(vParam, vParkingFk);
ELSEIF (SELECT TRUE FROM ticket WHERE id = vParam AND shipped >= vLastWeek) THEN ELSEIF (SELECT TRUE FROM ticket WHERE id = vParam AND shipped >= vLastWeek) THEN
CALL ticket_setParking(vParam, vParkingFk); CALL ticket_setParking(vParam, vParkingFk);
ELSEIF (SELECT TRUE FROM `collection` WHERE id = vParam AND created >= vLastWeek) THEN ELSEIF (SELECT TRUE FROM `collection` WHERE id = vParam AND created >= vLastWeek) THEN
CALL collection_setParking(vParam, vParkingFk); CALL collection_setParking(vParam, vParkingFk);
ELSEIF (SELECT TRUE FROM shelving WHERE code = vParam COLLATE utf8_unicode_ci) THEN
CALL shelving_setParking(vParam, vParkingFk);
END IF; END IF;
ELSE ELSE
guillermo marked this conversation as resolved Outdated
carlosap commented 2024-07-11 12:44:40 +00:00
Outdated
Review
Copy Link

Para que se quede mejor el procedimiento, como ya lo estamos refactorizando en el ELSE pondríamos un THROW y la opción del shelving haríamos lo mismo que en las anteriores, comprobar con la SELECT si existe antes de llamarlo

Para que se quede mejor el procedimiento, como ya lo estamos refactorizando en el ELSE pondríamos un THROW y la opción del shelving haríamos lo mismo que en las anteriores, comprobar con la SELECT si existe antes de llamarlo
-- Por descarte, se considera una matrícula CALL util.throw('paramNotExist');
guillermo marked this conversation as resolved Outdated
carlosap commented 2024-07-10 08:15:22 +00:00
Outdated
Review
Copy Link

No hay START TRANSACTION

No hay START TRANSACTION
CALL shelving_setParking(vParam, vParkingFk);
END IF; END IF;
COMMIT; COMMIT;