verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refactor: refs #7662 Added transaction #2702

Merged
guillermo merged 4 commits from 7662-ticketSplitPackingType into dev 2024-07-09 07:49:10 +00:00
Conversation 1 Commits 4 Files Changed 1 +56 -40
guillermo commented 2024-07-08 11:57:26 +00:00
Member
Copy Link
No description provided.
guillermo added 1 commit 2024-07-08 11:57:27 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
86859c98e3 refactor: refs #7662 Added transaction
guillermo added 1 commit 2024-07-08 12:01:20 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
32793990ec refactor: refs #7662 Minor change
guillermo added 1 commit 2024-07-08 12:11:58 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
eaca342777 refactor: refs #7662 Minor change
guillermo commented 2024-07-08 12:12:43 +00:00
Author
Member
Copy Link

La tabla temporal tmp.ticketIPT no la puedo pasar a tTicketIPT porque es utilizada en TPV por una cosa que implementó Pako.

La tabla temporal tmp.ticketIPT no la puedo pasar a tTicketIPT porque es utilizada en TPV por una cosa que implementó Pako.
guillermo requested review from jgallego 2024-07-08 12:13:28 +00:00
jgallego requested changes 2024-07-09 05:47:53 +00:00
Dismissed
db/routines/vn/procedures/ticket_splitItemPackingType.sql Outdated
@ -10,4 +10,1 @@
*
* @param vTicketFk Identificador de vn.ticket
* @param vOriginalItemPackingTypeFk Tipo para el que se reserva el número de ticket original
* @return table tmp.ticketIPT(ticketFk, itemPackingTypeFk)
jgallego commented 2024-07-09 05:44:54 +00:00
Owner
Copy Link

esta linea no la lleves perque realment ixa taula es torna, i qui cride ha de saber que deuria borrarla.

esta linea no la lleves perque realment ixa taula es torna, i qui cride ha de saber que deuria borrarla.
guillermo commented 2024-07-09 06:46:12 +00:00
Author
Member
Copy Link

Lo había quitado porque pensaba que no hacia falta y se podía transformar en tTable.
Pero no #2702 (comment)

Lo había quitado porque pensaba que no hacia falta y se podía transformar en tTable. Pero no https://gitea.verdnatura.es/verdnatura/salix/pulls/2702#issuecomment-57000
guillermo marked this conversation as resolved
db/routines/vn/procedures/ticket_splitItemPackingType.sql Outdated
@ -95,0 +101,4 @@
FROM sale s
JOIN tSale ts ON ts.id = s.id
JOIN tmp.ticketIPT t ON t.itemPackingTypeFk = ts.itemPackingTypeFk
WHERE s.ticketFk = vSelf
jgallego commented 2024-07-09 05:41:56 +00:00
Owner
Copy Link

este where es redundant perque tSale ja ve filtrada

este where es redundant perque tSale ja ve filtrada
guillermo marked this conversation as resolved
guillermo added 1 commit 2024-07-09 06:43:06 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
6430fb5b51 refactor: refs #7662 Requested changes
guillermo requested review from jgallego 2024-07-09 06:45:21 +00:00
jgallego approved these changes 2024-07-09 07:41:11 +00:00
guillermo merged commit 40461fb89e into dev 2024-07-09 07:49:10 +00:00
guillermo deleted branch 7662-ticketSplitPackingType 2024-07-09 07:49:10 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2702
No description provided.
Delete Branch "7662-ticketSplitPackingType"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?