verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 59 Releases Wiki Activity

refactor: refs #7662 Added transaction #2702

Merged
guillermo merged 4 commits from 7662-ticketSplitPackingType into dev 2024-07-09 07:49:10 +00:00
Conversation 1 Commits 4 Files Changed 1 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 6430fb5b51 - Show all commits

2
db/routines/vn/procedures/ticket_splitItemPackingType.sql
View File

@ -10,6 +10,7 @@ BEGIN
*
* @param vSelf Id ticket
* @param vItemPackingTypeFk Tipo para el que se reserva el número de ticket original
* @return table tmp.ticketIPT(ticketFk, itemPackingTypeFk)
*/
guillermo marked this conversation as resolved Outdated
jgallego commented 2024-07-09 05:44:54 +00:00
Outdated
Review
Copy Link

esta linea no la lleves perque realment ixa taula es torna, i qui cride ha de saber que deuria borrarla.

esta linea no la lleves perque realment ixa taula es torna, i qui cride ha de saber que deuria borrarla.
guillermo commented 2024-07-09 06:46:12 +00:00
Review
Copy Link

Lo había quitado porque pensaba que no hacia falta y se podía transformar en tTable.
Pero no #2702 (comment)

Lo había quitado porque pensaba que no hacia falta y se podía transformar en tTable. Pero no https://gitea.verdnatura.es/verdnatura/salix/pulls/2702#issuecomment-57000
DECLARE vItemPackingTypeFk VARCHAR(1) DEFAULT 'H';
DECLARE vNewTicketFk INT;
@ -101,7 +102,6 @@ BEGIN
FROM sale s
JOIN tSale ts ON ts.id = s.id
JOIN tmp.ticketIPT t ON t.itemPackingTypeFk = ts.itemPackingTypeFk
guillermo marked this conversation as resolved Outdated
jgallego commented 2024-07-09 05:41:56 +00:00
Outdated
Review
Copy Link

este where es redundant perque tSale ja ve filtrada

este where es redundant perque tSale ja ve filtrada
WHERE s.ticketFk = vSelf
FOR UPDATE;
UPDATE sale s