verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

feat: refs #7685 delivery coordinates #2706

Merged
robert merged 10 commits from 7685-delivery_beforeDeadlock into dev 2024-07-12 05:22:13 +00:00
Conversation 0 Commits 10 Files Changed 3 +33 -22
3 changed files with 33 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
db/routines/vn/procedures/address_updateCoordinates.sql Normal file
View File

@ -0,0 +1,25 @@
DELIMITER $$
CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`address_updateCoordinates`(
vTicketFk INT,
vLongitude INT,
vLatitude INT)
BEGIN
/**
* Actualiza las coordenadas de una dirección.
robert marked this conversation as resolved Outdated
guillermo commented 2024-07-11 09:11:37 +00:00
Outdated
Review
Copy Link

Actualiza las coordenadas de una dirección. (Acento y punto al final)

Actualiza las coordenadas de una dirección. (Acento y punto al final)
guillermo commented 2024-07-11 09:49:49 +00:00
Outdated
Review
Copy Link

El punto del final, te lo he puesto en el anterior comentario...

El punto del final, te lo he puesto en el anterior comentario...
*
* @param vTicketFk Id del ticket
robert marked this conversation as resolved Outdated
guillermo commented 2024-07-11 09:12:04 +00:00
Outdated
Review
Copy Link

Al empezar la descripción siempre mayuscula sin punto al final

Al empezar la descripción siempre mayuscula sin punto al final
* @param vLongitude Longitud de la dirección
robert marked this conversation as resolved Outdated
guillermo commented 2024-07-11 09:13:07 +00:00
Outdated
Review
Copy Link

Acentos

Acentos
* @param vLatitude Latitud de la dirección
*/
DECLARE vAddressFK INT;
SELECT addressFK INTO vAddressFK
FROM ticket
WHERE id = vTicketFk;
UPDATE address
SET longitude = vLongitude,
latitude = vLatitude
WHERE id = vAddressFK;
END$$
robert marked this conversation as resolved
guillermo commented 2024-07-11 09:12:54 +00:00
Review
Copy Link

Quitar salto de linea

Quitar salto de linea
DELIMITER ;

15
db/routines/vn/triggers/delivery_beforeInsert.sql
View File

@ -3,18 +3,11 @@ CREATE OR REPLACE DEFINER=`root`@`localhost` TRIGGER `vn`.`delivery_beforeInsert
BEFORE INSERT ON `delivery`
FOR EACH ROW
BEGIN
IF (NEW.longitude IS NOT NULL AND NEW.latitude IS NOT NULL AND NEW.ticketFK IS NOT NULL)
IF (NEW.longitude IS NOT NULL
AND NEW.latitude IS NOT NULL
robert marked this conversation as resolved Outdated
guillermo commented 2024-07-11 09:13:49 +00:00
Outdated
Review
Copy Link

Sobrepasa los caracteres máximos por linea, aplica esto al otro tmb

Sobrepasa los caracteres máximos por linea, aplica esto al otro tmb
AND NEW.ticketFK IS NOT NULL)
robert marked this conversation as resolved Outdated
guillermo commented 2024-07-11 09:13:24 +00:00
Outdated
Review
Copy Link

address_updateCoordinates(NEW.ticketFk, NEW.longitude, NEW.latitude);

Espacio despues de coma, aplica esto al otro tmb

address_updateCoordinates(NEW.ticketFk, NEW.longitude, NEW.latitude); Espacio despues de coma, aplica esto al otro tmb
THEN
UPDATE address
SET longitude = NEW.longitude,
latitude = NEW.latitude
WHERE id IN (
SELECT addressFK
FROM ticket
WHERE id = NEW.ticketFk
);
CALL address_updateCoordinates(NEW.ticketFk, NEW.longitude, NEW.latitude);
END IF;
END$$
DELIMITER ;

15
db/routines/vn/triggers/delivery_beforeUpdate.sql
View File

@ -3,18 +3,11 @@ CREATE OR REPLACE DEFINER=`root`@`localhost` TRIGGER `vn`.`delivery_beforeUpdate
BEFORE UPDATE ON `delivery`
FOR EACH ROW
BEGIN
IF (NEW.longitude IS NOT NULL AND NEW.latitude IS NOT NULL AND NEW.ticketFK IS NOT NULL)
IF (NEW.longitude IS NOT NULL
AND NEW.latitude IS NOT NULL
AND NEW.ticketFK IS NOT NULL)
THEN
UPDATE address
SET longitude = NEW.longitude,
latitude = NEW.latitude
WHERE id IN (
SELECT addressFK
FROM ticket
WHERE id = NEW.ticketFk
);
CALL address_updateCoordinates(NEW.ticketFk, NEW.longitude, NEW.latitude);
END IF;
END$$
DELIMITER ;