feat: refs #7685 delivery coordinates #2706

Merged
robert merged 10 commits from 7685-delivery_beforeDeadlock into dev 2024-07-12 05:22:13 +00:00
3 changed files with 33 additions and 22 deletions

View File

@ -0,0 +1,25 @@
DELIMITER $$
CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`address_updateCoordinates`(
vTicketFk INT,
vLongitude INT,
vLatitude INT)
BEGIN
/**
* Actualiza las coordenadas de una dirección.
robert marked this conversation as resolved Outdated

Actualiza las coordenadas de una dirección. (Acento y punto al final)

Actualiza las coordenadas de una dirección. (Acento y punto al final)

El punto del final, te lo he puesto en el anterior comentario...

El punto del final, te lo he puesto en el anterior comentario...
*
* @param vTicketFk Id del ticket
robert marked this conversation as resolved Outdated

Al empezar la descripción siempre mayuscula sin punto al final

Al empezar la descripción siempre mayuscula sin punto al final
* @param vLongitude Longitud de la dirección
robert marked this conversation as resolved Outdated

Acentos

Acentos
* @param vLatitude Latitud de la dirección
*/
DECLARE vAddressFK INT;
SELECT addressFK INTO vAddressFK
FROM ticket
WHERE id = vTicketFk;
UPDATE address
SET longitude = vLongitude,
latitude = vLatitude
WHERE id = vAddressFK;
END$$
robert marked this conversation as resolved
Review

Quitar salto de linea

Quitar salto de linea
DELIMITER ;

View File

@ -3,18 +3,11 @@ CREATE OR REPLACE DEFINER=`root`@`localhost` TRIGGER `vn`.`delivery_beforeInsert
BEFORE INSERT ON `delivery` BEFORE INSERT ON `delivery`
FOR EACH ROW FOR EACH ROW
BEGIN BEGIN
IF (NEW.longitude IS NOT NULL
IF (NEW.longitude IS NOT NULL AND NEW.latitude IS NOT NULL AND NEW.ticketFK IS NOT NULL) AND NEW.latitude IS NOT NULL
robert marked this conversation as resolved Outdated

Sobrepasa los caracteres máximos por linea, aplica esto al otro tmb

Sobrepasa los caracteres máximos por linea, aplica esto al otro tmb
AND NEW.ticketFK IS NOT NULL)
robert marked this conversation as resolved Outdated

address_updateCoordinates(NEW.ticketFk, NEW.longitude, NEW.latitude);

Espacio despues de coma, aplica esto al otro tmb

address_updateCoordinates(NEW.ticketFk, NEW.longitude, NEW.latitude); Espacio despues de coma, aplica esto al otro tmb
THEN THEN
UPDATE address CALL address_updateCoordinates(NEW.ticketFk, NEW.longitude, NEW.latitude);
SET longitude = NEW.longitude,
latitude = NEW.latitude
WHERE id IN (
SELECT addressFK
FROM ticket
WHERE id = NEW.ticketFk
);
END IF; END IF;
END$$ END$$
DELIMITER ; DELIMITER ;

View File

@ -3,18 +3,11 @@ CREATE OR REPLACE DEFINER=`root`@`localhost` TRIGGER `vn`.`delivery_beforeUpdate
BEFORE UPDATE ON `delivery` BEFORE UPDATE ON `delivery`
FOR EACH ROW FOR EACH ROW
BEGIN BEGIN
IF (NEW.longitude IS NOT NULL
IF (NEW.longitude IS NOT NULL AND NEW.latitude IS NOT NULL AND NEW.ticketFK IS NOT NULL) AND NEW.latitude IS NOT NULL
AND NEW.ticketFK IS NOT NULL)
THEN THEN
UPDATE address CALL address_updateCoordinates(NEW.ticketFk, NEW.longitude, NEW.latitude);
SET longitude = NEW.longitude,
latitude = NEW.latitude
WHERE id IN (
SELECT addressFK
FROM ticket
WHERE id = NEW.ticketFk
);
END IF; END IF;
END$$ END$$
DELIMITER ; DELIMITER ;