verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

hotfix fix createWorker business #2725

Closed
carlossa wants to merge 1 commits from hotfix-workerCountryValidate into master
pull from: hotfix-workerCountryValidate
merge into: verdnatura:master
Conversation 1 Commits 1 Files Changed 3 +8 -4
carlossa commented 2024-07-12 09:42:07 +00:00
Member
Copy Link
No description provided.
carlossa added 1 commit 2024-07-12 09:42:08 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
79f6ac6b76 hotfix fix createWorker business
carlossa requested review from alexm 2024-07-12 09:43:09 +00:00
carlossa requested review from jgallego 2024-07-12 09:44:11 +00:00
jgallego approved these changes 2024-07-12 09:56:29 +00:00
alexm requested changes 2024-07-12 10:15:25 +00:00
modules/worker/back/methods/worker/new.js
@ -203,3 +203,3 @@
fi,
birth,
provinceFk,
alexm commented 2024-07-12 10:14:55 +00:00
Member
Copy Link

Worker no tiene el campo provinceFk ni countryFk, el unico que tiene es originCountryFk

Worker no tiene el campo provinceFk ni countryFk, el unico que tiene es originCountryFk
modules/worker/back/models/worker.js
@ -27,13 +27,17 @@ module.exports = Self => {
});
async function tinIsValid(err, done) {
const countryFk = {
alexm commented 2024-07-12 10:15:23 +00:00
Member
Copy Link

Este enfoque no lo acabo de ver, se deberia sacar del originCountryFk

Este enfoque no lo acabo de ver, se deberia sacar del originCountryFk
alexm commented 2024-07-12 10:15:59 +00:00
Member
Copy Link

He creado esta PR #2728

He creado esta PR https://gitea.verdnatura.es/verdnatura/salix/pulls/2728
alexm closed this pull request 2024-07-12 10:16:00 +00:00
alexm deleted branch hotfix-workerCountryValidate 2024-07-12 10:27:01 +00:00
All checks were successful
gitea/salix/pipeline/pr-master This commit looks good
Required
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2725
No description provided.
Delete Branch "hotfix-workerCountryValidate"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?