verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

feat: refs #6403 add delete #2743

Merged
pablone merged 3 commits from 6403-feat-add-mrw-delete-on-salix into dev 2024-07-17 05:36:45 +00:00
Conversation 0 Commits 3 Files Changed 2 +16 -9
pablone commented 2024-07-16 11:26:36 +00:00
Member
Copy Link
No description provided.
pablone added 1 commit 2024-07-16 11:26:36 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
b7e84f43de feat: refs #6403 add delete
alexm reviewed 2024-07-16 11:29:36 +00:00
back/methods/mrw-config/cancelShipment.js
@ -40,3 +40,3 @@
const parser = new DOMParser();
const xmlDoc = parser.parseFromString(xmlString, 'text/xml');
return xmlDoc.getElementsByTagName('Mensaje')[0].textContent;
const result = xmlDoc.getElementsByTagName('Mensaje')[0].textContent;
alexm commented 2024-07-16 11:29:36 +00:00
Member
Copy Link

const [{textContent}] = xmlDoc.getElementsByTagName('Mensaje')
return textContent.toLowerCase().includes('se ha cancelado correctamente');

const [{textContent}] = xmlDoc.getElementsByTagName('Mensaje') return textContent.toLowerCase().includes('se ha cancelado correctamente');
pablone marked this conversation as resolved
alexm approved these changes 2024-07-16 11:29:38 +00:00
Dismissed
pablone added 1 commit 2024-07-16 11:43:43 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
9e007bfb8a fix: refs #6403 fix mrw cancel shipment return type
pablone added 1 commit 2024-07-16 11:44:58 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
d2f022ab64 Merge branch 'dev' into 6403-feat-add-mrw-delete-on-salix
alexm approved these changes 2024-07-16 11:47:58 +00:00
pablone merged commit 0ae1de5c88 into dev 2024-07-17 05:36:45 +00:00
pablone deleted branch 6403-feat-add-mrw-delete-on-salix 2024-07-17 05:36:45 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2743
No description provided.
Delete Branch "6403-feat-add-mrw-delete-on-salix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?