verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

feat: refs #6403 add cancelShipment on deleteExpeditions #2747

Merged
pablone merged 2 commits from 6403-featDeleteMrw into master 2024-07-17 06:25:33 +00:00
Conversation 0 Commits 2 Files Changed 2 +14 -9
pablone commented 2024-07-17 06:18:27 +00:00
Member
Copy Link
No description provided.
pablone added 1 commit 2024-07-17 06:18:28 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
0ea69427ec feat: refs #6403 add cancelShipment on deleteExpeditions
alexm reviewed 2024-07-17 06:21:18 +00:00
alexm requested changes 2024-07-17 06:21:39 +00:00
Dismissed
modules/ticket/back/methods/expedition/deleteExpeditions.js Outdated
@ -48,2 +49,2 @@
if (code && code.toLowerCase().substring(0, 10) == 'viaexpress') {
const isDeleted = await models.ViaexpressConfig.deleteExpedition(expeditionId);
if (code?.toLowerCase()?.includes('mrw')) {
const result = await models.MrwConfig.cancelShipment(expeditionId);
alexm commented 2024-07-17 06:21:37 +00:00
Member
Copy Link

isDeleted = await models.MrwConfig.cancelShipment(expeditionId);

isDeleted = await models.MrwConfig.cancelShipment(expeditionId);
pablone marked this conversation as resolved
pablone added 1 commit 2024-07-17 06:23:38 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
f83dd37a28 fix: refs #6403 remove line
alexm approved these changes 2024-07-17 06:24:37 +00:00
pablone merged commit b5728b43f0 into master 2024-07-17 06:25:33 +00:00
pablone deleted branch 6403-featDeleteMrw 2024-07-17 06:25:33 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2747
No description provided.
Delete Branch "6403-featDeleteMrw"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?