verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

6943-fixCustomer #2754

Merged
alexm merged 3 commits from 6943-fixCustomer into dev 2024-07-18 12:01:08 +00:00
Conversation 0 Commits 3 Files Changed 1 +16 -7
alexm commented 2024-07-18 06:39:07 +00:00
Member
Copy Link
No description provided.
alexm added 2 commits 2024-07-18 06:39:07 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
e66d138091 feat(defaulter_filter): add department
alexm requested review from jsegarra 2024-07-18 06:39:12 +00:00
alexm reviewed 2024-07-18 06:40:08 +00:00
modules/client/back/methods/defaulter/filter.js
@ -80,2 +82,4 @@
LEFT JOIN clientObservation co ON co.clientFk = c.id
LEFT JOIN account.user u ON u.id = c.salesPersonFk
LEFT JOIN account.user uw ON uw.id = co.workerFk
LEFT JOIN (
alexm commented 2024-07-18 06:40:08 +00:00
Author
Member
Copy Link

@jgallego no estoy del todo seguro de este LEFT JOIN pero mejor de como esta ahora en el front es seguro y creo que lo que se queria era asi

@jgallego no estoy del todo seguro de este LEFT JOIN pero mejor de como esta ahora en el front es seguro y creo que lo que se queria era asi
jgallego commented 2024-07-22 08:08:29 +00:00
Owner
Copy Link

CUIDAOO!!! Lo que has posat sols trau un registre..i no saps de quin client!

Proposta: si sols vols vore si teu n f.finished null, fes un left join simple, sense subconsulta
LEFT JOIN recovery r ON r.clientFk = c.id AND r.finished IS NULL
i en el select si r.id entonces has Recovery

CUIDAOO!!! Lo que has posat sols trau un registre..i no saps de quin client! Proposta: si sols vols vore si teu n f.finished null, fes un left join simple, sense subconsulta `LEFT JOIN recovery r ON r.clientFk = c.id AND r.finished IS NULL` i en el select si r.id entonces has Recovery
jsegarra commented 2024-07-22 08:41:11 +00:00
Member
Copy Link

@jgallego con LEFT JOIN salen los mismos registros que hay con el código antiguo, por eso nos e pusieron cambios y se aprobó.

@jgallego con LEFT JOIN salen los mismos registros que hay con el código antiguo, por eso nos e pusieron cambios y se aprobó.
jgallego commented 2024-07-22 08:56:01 +00:00
Owner
Copy Link
SELECT MAX(started), clientFk, finished
                                FROM recovery

Esto hay que quitarlo ya que saca datos falsos

``` SELECT MAX(started), clientFk, finished FROM recovery ``` Esto hay que quitarlo ya que saca datos falsos
jsegarra approved these changes 2024-07-18 07:33:08 +00:00
alexm added 1 commit 2024-07-18 11:58:22 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
c30362a266 Merge branch 'dev' into 6943-fixCustomer
alexm merged commit 41ed73cb28 into dev 2024-07-18 12:01:08 +00:00
alexm deleted branch 6943-fixCustomer 2024-07-18 12:01:08 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2754
No description provided.
Delete Branch "6943-fixCustomer"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?