verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

fix: defaulter filter correct sql #2779

Merged
alexm merged 1 commits from 6943-fix_defaulter_filter into dev 2024-07-23 12:47:53 +00:00
Conversation 0 Commits 1 Files Changed 1 +1
alexm commented 2024-07-23 12:37:47 +00:00
Member
Copy Link
No description provided.
alexm added 1 commit 2024-07-23 12:37:48 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
1a3ed42bcd fix: defaulter filter correct sql
alexm requested review from pablone 2024-07-23 12:38:00 +00:00
alexm reviewed 2024-07-23 12:38:50 +00:00
modules/client/back/methods/defaulter/filter.js
@ -85,6 +85,7 @@ module.exports = Self => {
LEFT JOIN (
SELECT MAX(started), clientFk, finished
FROM recovery
GROUP BY clientFk
alexm commented 2024-07-23 12:38:50 +00:00
Author
Member
Copy Link

@jgallego aixina valdria, pq per a cada client traguem la maxima
https://gitea.verdnatura.es/verdnatura/salix/pulls/2754/files#issuecomment-58376

@jgallego aixina valdria, pq per a cada client traguem la maxima https://gitea.verdnatura.es/verdnatura/salix/pulls/2754/files#issuecomment-58376
pablone approved these changes 2024-07-23 12:46:56 +00:00
alexm merged commit 1f9cacedad into dev 2024-07-23 12:47:53 +00:00
alexm deleted branch 6943-fix_defaulter_filter 2024-07-23 12:47:53 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
pablone
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2779
No description provided.
Delete Branch "6943-fix_defaulter_filter"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?