#7663 setWeight #2817

Merged
jorgep merged 24 commits from 7663-setWeight into dev 2024-09-11 07:40:32 +00:00
Member
No description provided.
jorgep added 1 commit 2024-07-31 08:44:44 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
57f6c6d9a1
chore: refs #7663 WIP setWeight
jorgep added 1 commit 2024-07-31 08:46:52 +00:00
jorgep added 1 commit 2024-08-12 14:59:34 +00:00
jorgep changed title from WIP: chore: refs #7663 WIP setWeight to WIP: #7663 setWeight 2024-08-12 14:59:51 +00:00
jorgep added 1 commit 2024-08-13 09:41:59 +00:00
jorgep added 1 commit 2024-08-13 11:49:05 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
52d62710e6
chore: refs #7663 fix logic
jorgep added 1 commit 2024-08-13 12:52:30 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
6c9676ce9c
chore: refs #7663 fix logic
jorgep added 1 commit 2024-08-14 14:29:19 +00:00
jorgep added 1 commit 2024-08-26 14:59:47 +00:00
jorgep added 1 commit 2024-09-02 15:02:13 +00:00
jorgep added 1 commit 2024-09-02 15:08:27 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
4c5f5c8324
fix: refs #7663 conflicts
jorgep added 1 commit 2024-09-03 07:09:03 +00:00
jorgep added 1 commit 2024-09-03 14:22:13 +00:00
jorgep added 1 commit 2024-09-03 15:33:49 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
9797d5e219
feat: refs #7663 return created invoice ids
jorgep added 1 commit 2024-09-04 08:39:53 +00:00
jorgep added 1 commit 2024-09-04 09:41:53 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
df5961a2a2
feat: refs #7663 wip test
jorgep added 1 commit 2024-09-05 06:56:21 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
998d3865a3
chore: refs #7663 fix test
jorgep added 1 commit 2024-09-06 09:30:12 +00:00
jorgep added 1 commit 2024-09-06 09:33:20 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
99ce158632
chore: refs #7663 return correct type
jorgep changed title from WIP: #7663 setWeight to #7663 setWeight 2024-09-06 09:57:48 +00:00
jorgep requested review from alexm 2024-09-06 09:59:10 +00:00
jorgep added the
CR / Tests passed
label 2024-09-06 10:16:57 +00:00
alexm reviewed 2024-09-09 09:39:16 +00:00
@ -0,0 +41,4 @@
try {
const ticket = await Self.findById(ticketId, null, myOptions);
if (ticket.weight) throw new UserError('Weight already set');
Member

Esta comprobación la han pedido?

Esta comprobación la han pedido?
Author
Member

Sí, me dijo que solo se debe de poder establecer el peso del ticket si no tiene.

Sí, me dijo que solo se debe de poder establecer el peso del ticket si no tiene.
alexm marked this conversation as resolved
alexm reviewed 2024-09-09 09:41:44 +00:00
alexm requested changes 2024-09-09 09:42:35 +00:00
Dismissed
@ -0,0 +59,4 @@
workerDepartments.length == 2 &&
workerDepartments[0].departmentFk != workerDepartments[1].departmentFk
)
throw new UserError('You don\'t have enough privileges');
Member

Yo daria un error mas especifico diciendo que no pueden pq no son del mismo equipo

Yo daria un error mas especifico diciendo que no pueden pq no son del mismo equipo
jorgep marked this conversation as resolved
jorgep added 1 commit 2024-09-10 07:42:02 +00:00
jorgep added 1 commit 2024-09-10 07:50:08 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
91abf2eefe
refactor: refs #7663 accurate error
jorgep requested review from alexm 2024-09-10 07:54:02 +00:00
alexm added 1 commit 2024-09-11 06:35:04 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
a65506aebd
Merge branch 'dev' into 7663-setWeight
alexm approved these changes 2024-09-11 06:35:45 +00:00
jorgep added 2 commits 2024-09-11 07:30:34 +00:00
jorgep added 1 commit 2024-09-11 07:35:30 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
2ee0c93e24
chore: refs #7663 fix test
jorgep merged commit d699d9f60c into dev 2024-09-11 07:40:32 +00:00
jorgep deleted branch 7663-setWeight 2024-09-11 07:40:32 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2817
No description provided.