verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refactor: refs #7644 Optimized barcode #2819

Open
guillermo wants to merge 7 commits from 7644-optimizedBarcode into master
pull from: 7644-optimizedBarcode
merge into: verdnatura:master
Conversation 0 Commits 7 Files Changed 5 +26 -16
guillermo commented 2024-07-31 09:33:25 +00:00
Member
Copy Link
No description provided.
guillermo added 1 commit 2024-07-31 09:33:26 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
1a2ed9ce68 refactor: refs #7644 Optimized barcode
guillermo added 1 commit 2024-07-31 09:33:47 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
ef017f41d5 Merge branch 'master' into 7644-optimizedBarcode
guillermo added 2 commits 2024-07-31 10:25:29 +00:00
guillermo requested review from alexm 2024-07-31 10:25:36 +00:00
alexm reviewed 2024-07-31 10:59:51 +00:00
print/templates/reports/buy-label/buy-label.js
@ -29,0 +33,4 @@
}
},
getBarcode(id) {
return this.barcodes.find(item => item.id === id).barcode;
alexm commented 2024-07-31 10:59:51 +00:00
Member
Copy Link

Podries haver fet que this.barcodes fora un Map (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map) axina despres sols has de accedir a ixe registre en concret encomter de buscar cada 1

https://www.measurethat.net/Benchmarks/Show/23555/5/arrayfind-vs-mapget#latest_results_block

Podries haver fet que this.barcodes fora un Map (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map) axina despres sols has de accedir a ixe registre en concret encomter de buscar cada 1 https://www.measurethat.net/Benchmarks/Show/23555/5/arrayfind-vs-mapget#latest_results_block
alexm approved these changes 2024-07-31 11:00:25 +00:00
guillermo added 1 commit 2024-07-31 12:20:41 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
fcca2b65c2 feat: refs #7644 Fix traduction
guillermo added 1 commit 2024-08-02 08:13:35 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
b1109af1e8 feat: refs #7644 Minor changes
guillermo added 1 commit 2024-08-02 09:08:30 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
76d8c6c668 feat: refs #7644 Minor changes
All checks were successful
gitea/salix/pipeline/pr-master This commit looks good
Required
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2819
No description provided.
Delete Branch "7644-optimizedBarcode"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?