verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

feat: refs #7644 Optimized entry labels report #2831

Merged
guillermo merged 3 commits from 7644-buyLabelChunk into master 2024-08-05 09:53:34 +00:00
Conversation 0 Commits 3 Files Changed 10 +149 -40
guillermo commented 2024-08-05 09:29:59 +00:00
Member
Copy Link
No description provided.
guillermo added 1 commit 2024-08-05 09:30:00 +00:00
gitea/salix/pipeline/pr-master There was a failure building this commit Details
ab446b54ed feat: refs #7644 Optimized entry labels report
guillermo requested review from alexm 2024-08-05 09:30:10 +00:00
alexm requested changes 2024-08-05 09:39:22 +00:00
Dismissed
print/templates/reports/buy-label/buy-label.js Outdated
@ -9,3 +9,2 @@
async serverPrefetch() {
this.buys = await this.rawSqlFromDef('buys', [this.id, this.id]);
this.maxLabelNum = Math.max(...this.buys.map(buy => buy.labelNum));
const models = require('vn-loopback/server/server').models;
alexm commented 2024-08-05 09:38:30 +00:00
Member
Copy Link

Dalt de tot on estan els altres require, posar:
const { models } = require('vn-loopback/server/server');

Dalt de tot on estan els altres require, posar: `const { models } = require('vn-loopback/server/server');`
guillermo marked this conversation as resolved
guillermo added 1 commit 2024-08-05 09:44:23 +00:00
gitea/salix/pipeline/pr-master There was a failure building this commit Details
760a1debca feat: refs #7644 Requested changes
guillermo requested review from alexm 2024-08-05 09:44:34 +00:00
alexm approved these changes 2024-08-05 09:48:03 +00:00
guillermo added 1 commit 2024-08-05 09:48:06 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
32b48a7bb6 feat: refs #7644 Fix
guillermo merged commit df672a22eb into master 2024-08-05 09:53:34 +00:00
guillermo deleted branch 7644-buyLabelChunk 2024-08-05 09:53:35 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2831
No description provided.
Delete Branch "7644-buyLabelChunk"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?