7836-futureEntries #2839

Merged
pako merged 5 commits from 7836-futureEntries into dev 2024-08-08 06:06:23 +00:00
Member
No description provided.
pako added 2 commits 2024-08-06 11:23:53 +00:00
gitea/salix/pipeline/pr-dev Build queued... Details
be5859b8cf
prototipo
gitea/salix/pipeline/pr-dev This commit looks good Details
dcdbb0bf93
Merge branch 'dev' into 7836-futureEntries
pako added 1 commit 2024-08-06 11:23:58 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
fc7c7beef7
Merge branch 'dev' into 7836-futureEntries
pako requested review from guillermo 2024-08-06 11:24:04 +00:00
guillermo requested changes 2024-08-06 12:30:35 +00:00
Dismissed
@ -0,0 +1,166 @@
DELIMITER $$
$$
Member

Esta linea sobra

Esta linea sobra
pako marked this conversation as resolved
@ -0,0 +35,4 @@
IFNULL(invoiceCurrency, 0), 2
) currencyBalance
FROM (
SELECT * FROM
Member

No podrías poner eL ORDER BY en la subconsulta para ahorrate este SELECT * FROM ?

No podrías poner eL ORDER BY en la subconsulta para ahorrate este `SELECT * FROM` ?
Author
Member

OK. Pensaba que el order by afectaría sólo a la última parte del UNION

OK. Pensaba que el order by afectaría sólo a la última parte del UNION
pako marked this conversation as resolved
@ -0,0 +64,4 @@
JOIN invoiceInDueDay iid ON iid.invoiceInFk = ii.id
JOIN currency c ON c.id = ii.currencyFk
JOIN invoiceInConfig iic
WHERE ii.issued >= iic.balanceStartingDate
Member

Como utilizas este campo iic.balanceStartingDate de la tabla invoiceInConfig, es mejor que lo setees en una variable, así no tienes que acceder a el 2 veces, sino 1.

https://wiki.verdnatura.es/index.php/Convenciones_SQL#Obtener_dato_de_una_tabla_config

Como utilizas este campo iic.balanceStartingDate de la tabla invoiceInConfig, es mejor que lo setees en una variable, así no tienes que acceder a el 2 veces, sino 1. https://wiki.verdnatura.es/index.php/Convenciones_SQL#Obtener_dato_de_una_tabla_config
Author
Member

ok

ok
pako marked this conversation as resolved
@ -0,0 +130,4 @@
FROM supplierExpense se
JOIN currency c ON c.id = se.currencyFk
WHERE se.supplierFk = vSupplierFk
AND vCurrencyFk IN (se.currencyFk,0)
Member

¿Por que pones un 0?

¿Por que pones un 0?
Author
Member

Para que al sumar un NULL no me devuelva toda la suma NULL

Para que al sumar un NULL no me devuelva toda la suma NULL
@ -0,0 +149,4 @@
FALSE isBooked,
c.code,
'order'
FROM vn.entry e
Member

Quitar vn.

Quitar vn.
pako marked this conversation as resolved
@ -0,0 +162,4 @@
IF(vOrderBy = 'dueDate', id, NULL)
LIMIT 10000000000000000000
) t;
END;$$
Member

END$$

END$$
pako marked this conversation as resolved
pako added 1 commit 2024-08-07 08:42:19 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
9b2cbcd5cc
reviewed
pako requested review from guillermo 2024-08-07 08:43:12 +00:00
guillermo approved these changes 2024-08-07 11:57:26 +00:00
pako added 1 commit 2024-08-08 06:01:38 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
a9cdbb1255
Merge branch 'dev' into 7836-futureEntries
pako merged commit c3da3b9bf3 into dev 2024-08-08 06:06:23 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2839
No description provided.