verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refs #7844 Change in problems calc #2842

Merged
guillermo merged 6 commits from 7844-changeProblemsCalc into dev 2024-08-27 08:07:26 +00:00
Conversation 0 Commits 6 Files Changed 8 +230 -315
guillermo commented 2024-08-07 08:33:01 +00:00
Member
Copy Link
No description provided.
guillermo added 1 commit 2024-08-07 08:33:02 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
ea75446982 refs #7844 Change in problems calc
guillermo added 1 commit 2024-08-07 08:40:14 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
4f2e343d0c refs #7844 Fix
guillermo added 1 commit 2024-08-07 10:39:22 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
8aa06e12b3 refs #7844 Fix tests part 1/2
guillermo added 1 commit 2024-08-07 11:51:04 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
4cbea3bf7b refs #7844 Fix tests part 2/2
guillermo added 1 commit 2024-08-07 11:52:45 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
09a0459a7b refs #7844 Fix tests part 2/2
guillermo requested review from jgallego 2024-08-07 12:02:22 +00:00
jgallego requested changes 2024-08-12 04:59:29 +00:00
Dismissed
db/routines/vn/procedures/sale_getProblems.sql
@ -56,0 +75,4 @@
JOIN ticket t ON t.id = sgp.ticketFk
LEFT JOIN sale s ON s.ticketFk = t.id
LEFT JOIN item i ON i.id = s.itemFk
WHERE s.problem <> '' OR t.problem <> '' OR t.risk
jgallego commented 2024-08-12 04:59:26 +00:00
Owner
Copy Link

quin cas pot haver que tinga t.risk pero no s'haja produit previament un problema? perque si es un problema deuria estar en hasRisk i si no ho es no contemplar-ho.

quin cas pot haver que tinga t.risk pero no s'haja produit previament un problema? perque si es un problema deuria estar en hasRisk i si no ho es no contemplar-ho.
guillermo commented 2024-08-12 09:10:47 +00:00
Author
Member
Copy Link

Hi han molts casos en el que hi ha t.risk pero no t.problem

Hi han molts casos en el que hi ha t.risk pero no t.problem
guillermo marked this conversation as resolved
db/routines/vn/procedures/sale_getProblems.sql
@ -239,2 +174,3 @@
GROUP BY sgp.ticketFk
) sub
ON DUPLICATE KEY UPDATE itemDelay = sub.problem, saleFk = sub.saleFk;
ON DUPLICATE KEY UPDATE itemLost = sub.problem, saleFk = sub.saleFk;
jgallego commented 2024-08-12 04:55:14 +00:00
Owner
Copy Link

este canvi es extrany, perque es canviaba avans el itemDelay?

este canvi es extrany, perque es canviaba avans el itemDelay?
guillermo commented 2024-08-12 09:09:26 +00:00
Author
Member
Copy Link

Ni idea, pareix ser que estaba mal perque no te sentit.

Ni idea, pareix ser que estaba mal perque no te sentit.
guillermo marked this conversation as resolved
guillermo requested review from jgallego 2024-08-12 09:10:50 +00:00
jgallego approved these changes 2024-08-12 14:52:26 +00:00
guillermo added 1 commit 2024-08-27 08:04:25 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
79e2424a41 Merge branch 'dev' into 7844-changeProblemsCalc
guillermo merged commit 724a9b5dc1 into dev 2024-08-27 08:07:26 +00:00
guillermo deleted branch 7844-changeProblemsCalc 2024-08-27 08:07:26 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2842
No description provided.
Delete Branch "7844-changeProblemsCalc"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?