verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

feat: refs #7758 Add code mandateType and accountDetailType #2876

Merged
ivanm merged 5 commits from 7758-Add_code_mandateType_accountDetailType into dev 2024-08-23 10:16:27 +00:00
Conversation 1 Commits 5 Files Changed 9 +28 -13
ivanm commented 2024-08-21 14:47:25 +00:00
Member
Copy Link
No description provided.
ivanm added 1 commit 2024-08-21 14:47:25 +00:00
ivanm added 1 commit 2024-08-21 14:49:08 +00:00
ivanm requested review from jgallego 2024-08-21 14:51:01 +00:00
jgallego requested changes 2024-08-23 06:16:19 +00:00
Dismissed
jgallego left a comment
Owner
Copy Link

pregunta a algu de l'equip salix com es tiren els test per si el teu canvi ha trencat algo

pregunta a algu de l'equip salix com es tiren els test per si el teu canvi ha trencat algo
db/dump/fixtures.before.sql Outdated
@ -3955,1 +3950,3 @@
(6, 'ABA');
(1, 'IBAN', 'IBAN'),
(2, 'SWIFT', 'SWIFT'),
(3, 'Referencia Remesas', 'REM'),
jgallego commented 2024-08-23 06:05:07 +00:00
Owner
Copy Link

codigos en ingles, pregunta a chatgpt,
el code
Se llamará code si es un identificador alfanumérico en lowerCamelCase[1], se añadirá como PRIMARY o UNIQUE, y siempre NOT NULL.

codigos en ingles, pregunta a chatgpt, el code `Se llamará code si es un identificador alfanumérico en lowerCamelCase[1], se añadirá como PRIMARY o UNIQUE, y siempre NOT NULL.`
ivanm commented 2024-08-23 08:45:52 +00:00
Author
Member
Copy Link

M'ha proposat 'remRef' com a Remittance Reference, 'trnRef' com a Transfer Reference i 'payRef' com a Payroll Reference.

Les fique en lowerCamelCase i com a UNIQUE ja que tenen 'id' que es el PRIMARY

M'ha proposat 'remRef' com a Remittance Reference, 'trnRef' com a Transfer Reference i 'payRef' com a Payroll Reference. Les fique en lowerCamelCase i com a UNIQUE ja que tenen 'id' que es el PRIMARY
ivanm marked this conversation as resolved
db/versions/11191-chocolateBirch/02-firstScript.sql Outdated
@ -0,0 +1,9 @@
UPDATE vn.accountDetailType
SET code = CASE id
jgallego commented 2024-08-23 06:15:35 +00:00
Owner
Copy Link

gasta el camp description, no es pot cambiar gastant id

gasta el camp description, no es pot cambiar gastant id
ivanm marked this conversation as resolved
ivanm added 1 commit 2024-08-23 06:25:08 +00:00
ivanm added 1 commit 2024-08-23 09:34:39 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
94461cff58 feat: refs #7758 Modify code lowerCamelCase and UNIQUE
ivanm added 1 commit 2024-08-23 09:36:08 +00:00
ivanm commented 2024-08-23 09:38:36 +00:00
Author
Member
Copy Link

Ja vaig tirar els test de back, front i e2e abans de pujar la PR. Els he tornat a tirar amb la modificació i no han donat error

Ja vaig tirar els test de back, front i e2e abans de pujar la PR. Els he tornat a tirar amb la modificació i no han donat error
ivanm requested review from jgallego 2024-08-23 09:39:29 +00:00
jgallego approved these changes 2024-08-23 10:06:32 +00:00
ivanm merged commit ffbcd1bd4a into dev 2024-08-23 10:16:27 +00:00
ivanm deleted branch 7758-Add_code_mandateType_accountDetailType 2024-08-23 10:16:27 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2876
No description provided.
Delete Branch "7758-Add_code_mandateType_accountDetailType"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?