verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refactor: refs #7817 itemShelving_addList change #2882

Merged
jgallego merged 7 commits from 7817-isChecked into dev 2024-10-03 05:34:45 +00:00
Conversation 0 Commits 7 Files Changed 3 +33 -19
guillermo commented 2024-08-26 12:06:26 +00:00
Member
Copy Link
No description provided.
guillermo added 1 commit 2024-08-26 12:06:26 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
5a22f009f2 refactor: refs #7817 itemShelving_addList change
guillermo changed title from refactor: refs #7817 itemShelving_addList change to WIP: refactor: refs #7817 itemShelving_addList change 2024-08-26 12:15:27 +00:00
guillermo added 1 commit 2024-09-16 07:17:24 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
d7e7647b52 Merge branch 'dev' into 7817-isChecked
guillermo requested review from carlosap 2024-09-16 07:18:19 +00:00
guillermo changed title from WIP: refactor: refs #7817 itemShelving_addList change to refactor: refs #7817 itemShelving_addList change 2024-09-16 07:18:24 +00:00
carlosap requested changes 2024-09-16 14:30:38 +00:00
db/routines/vn/procedures/itemShelving_addList.sql Outdated
@ -32,4 +38,4 @@
AND itemFk = vItemFk;
END IF;
IF NOT (vIsChecking AND vIsChecked) THEN
carlosap commented 2024-09-16 14:25:13 +00:00
Member
Copy Link

Seria más legible sin el NOT y con un OR

Seria más legible sin el NOT y con un OR
guillermo marked this conversation as resolved
db/routines/vn/procedures/itemShelving_addList.sql
@ -37,3 +43,3 @@
END IF;
UPDATE vn.itemShelving
UPDATE itemShelving
carlosap commented 2024-09-16 14:24:25 +00:00
Member
Copy Link

Revisar la lógica del procedimiento, no tiene sentido hacer este UPDATE si el parámetro vIsChecking = FALSE

Revisar la lógica del procedimiento, no tiene sentido hacer este UPDATE si el parámetro vIsChecking = FALSE
guillermo commented 2024-09-17 10:27:07 +00:00
Author
Member
Copy Link

Sí que tiene, porque ese campo puede tener NULL, TRUE o FALSE, si es NULL y la variables es FALSE, quieres que haga el UPDATE a FALSE

Sí que tiene, porque ese campo puede tener NULL, TRUE o FALSE, si es NULL y la variables es FALSE, quieres que haga el UPDATE a FALSE
guillermo marked this conversation as resolved
db/versions/11198-blackPhormium/00-firstScript.sql
@ -0,0 +1,7 @@
UPDATE vn.itemShelving
SET isChecked = TRUE
WHERE isChecked;
carlosap commented 2024-09-16 14:30:33 +00:00
Member
Copy Link

AND isChecked <> 1

AND isChecked <> 1
guillermo commented 2024-09-17 10:25:57 +00:00
Author
Member
Copy Link

No fa falta, ho he comprovat.

No fa falta, ho he comprovat.
guillermo marked this conversation as resolved
guillermo added 1 commit 2024-09-17 10:30:13 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
acdaa96211 refactor: refs #7817 Requested changes
guillermo requested review from carlosap 2024-09-17 10:30:27 +00:00
guillermo added 1 commit 2024-09-17 10:30:33 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
be30e5ae1f Merge branch 'dev' into 7817-isChecked
carlosap requested review from jgallego 2024-09-23 12:43:43 +00:00
carlosap refused to review 2024-09-23 12:43:46 +00:00
jgallego approved these changes 2024-09-24 05:17:13 +00:00
Dismissed
db/routines/vn/procedures/itemShelving_addList.sql
@ -28,3 +34,2 @@
SELECT COUNT(*) INTO vIsChecked
FROM vn.itemShelving
SELECT IF(COUNT(*), TRUE, FALSE) INTO vIsChecked
jgallego commented 2024-09-24 05:16:32 +00:00
Owner
Copy Link

altra forma de fer-ho:
SELECT COUNT(*) > 0 INTO checked

altra forma de fer-ho: SELECT COUNT(*) > 0 INTO checked
guillermo marked this conversation as resolved
guillermo added 1 commit 2024-10-01 05:56:51 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
94636e1c19 Merge branch 'dev' into 7817-isChecked
guillermo added 1 commit 2024-10-01 06:59:47 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
f94ace05cc Merge branch 'dev' into 7817-isChecked
guillermo added 1 commit 2024-10-01 07:18:20 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
4243cdbf50 fix: refs #7817 Tests back
guillermo requested review from jgallego 2024-10-01 07:20:15 +00:00
guillermo requested review from carlosap 2024-10-01 07:20:17 +00:00
jgallego approved these changes 2024-10-01 08:02:45 +00:00
jgallego merged commit 5f695f63b3 into dev 2024-10-03 05:34:45 +00:00
jgallego deleted branch 7817-isChecked 2024-10-03 05:34:45 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosap
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2882
No description provided.
Delete Branch "7817-isChecked"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?