verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

fix: refs #7213 Hotfix-ticket_isTooLittle-group-by-addressFk #2895

Merged
carlosap merged 3 commits from Hotfix-ticket_isTooLittle-group-by-addressFk into master 2024-08-28 14:41:49 +00:00
Conversation 0 Commits 3 Files Changed 2 +31 -14
carlosap commented 2024-08-27 15:42:19 +00:00
Member
Copy Link
No description provided.
carlosap added 2 commits 2024-08-27 15:42:20 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
1ec9e5bf09 Hotfix: refs #7213 ticket_isTooLittle group by addressFk
carlosap requested review from guillermo 2024-08-27 15:42:30 +00:00
guillermo requested changes 2024-08-28 05:28:00 +00:00
Dismissed
db/routines/vn/functions/ticket_isTooLittle.sql Outdated
@ -12,13 +12,20 @@ BEGIN
* @return BOOL
*/
DECLARE vIsTooLittle TINYINT(1);
guillermo commented 2024-08-28 05:15:46 +00:00
Member
Copy Link

BOOL, i dalt en el RETURNS tame BOOL

BOOL, i dalt en el RETURNS tame BOOL
carlosap marked this conversation as resolved
db/routines/vn/functions/ticket_isTooLittle.sql Outdated
@ -14,2 +14,3 @@
DECLARE vIsTooLittle TINYINT(1);
WITH tickets AS (
guillermo commented 2024-08-28 05:18:14 +00:00
Member
Copy Link

Aço es soles una observació, crec que no te sentit dir-li tickets si soles es 1 ticket, jo li diría ticketAddress o algo per l'estil

Aço es soles una observació, crec que no te sentit dir-li tickets si soles es 1 ticket, jo li diría ticketAddress o algo per l'estil
carlosap marked this conversation as resolved
db/routines/vn/procedures/ticket_setProblemTooLittle.sql Outdated
@ -15,3 +15,1 @@
SELECT vSelf ticketFk,
ticket_isTooLittle(vSelf) hasProblem,
ticket_isProblemCalcNeeded(vSelf) isProblemCalcNeeded;
WITH tickets AS (
guillermo commented 2024-08-28 05:20:34 +00:00
Member
Copy Link

Lo mateix que ací #2895 (comment)

Lo mateix que ací https://gitea.verdnatura.es/verdnatura/salix/pulls/2895#issuecomment-61020
carlosap marked this conversation as resolved
db/routines/vn/procedures/ticket_setProblemTooLittle.sql Outdated
@ -18,0 +17,4 @@
FROM vn.ticket
WHERE id = vSelf
)
SELECT t.id ticketFk,
guillermo commented 2024-08-28 05:27:57 +00:00
Member
Copy Link

Ací estás pasant per cada ticket per la funció vn.ticket_isTooLittle(), no et fa falta, jo ficaria el SELECT amb el ticket vSelf dalt en una variable, ja que tots els tickets te van a donar lo mateix.

Entenc tot lo demes, ja que si que te interesa cridar a la funció ticket_isProblemCalcNeeded per cada ticket.

Ací estás pasant per cada ticket per la funció `vn.ticket_isTooLittle()`, no et fa falta, jo ficaria el SELECT amb el ticket vSelf dalt en una variable, ja que tots els tickets te van a donar lo mateix. Entenc tot lo demes, ja que si que te interesa cridar a la funció `ticket_isProblemCalcNeeded` per cada ticket.
carlosap marked this conversation as resolved
guillermo changed title from Hotfix-ticket_isTooLittle-group-by-addressFk to fix: refs #7213 Hotfix-ticket_isTooLittle-group-by-addressFk 2024-08-28 05:28:39 +00:00
carlosap added 1 commit 2024-08-28 09:59:50 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
423ba8c218 Hotfix: refs #7213 ticket_isTooLittle group by addressFk
carlosap requested review from guillermo 2024-08-28 10:16:50 +00:00
guillermo approved these changes 2024-08-28 11:44:13 +00:00
carlosap merged commit 88246174dc into master 2024-08-28 14:41:49 +00:00
carlosap deleted branch Hotfix-ticket_isTooLittle-group-by-addressFk 2024-08-28 14:41:49 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
guillermo
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2895
No description provided.
Delete Branch "Hotfix-ticket_isTooLittle-group-by-addressFk"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?