#7277 - RefundInvoices #2904

Merged
jgallego merged 12 commits from 7277-RefundInvoices into dev 2024-09-05 09:07:25 +00:00
Owner
No description provided.
jgallego added 2 commits 2024-08-30 11:52:17 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
c45a861ef4
feat: refs #7277 fdescribe
jgallego added 1 commit 2024-08-30 11:56:48 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
ac36762e21
feat: refs #7277 fdescribe
jgallego added 1 commit 2024-08-30 12:03:21 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
2e3fb7646f
feat: refs #7277 fit
jgallego added 1 commit 2024-08-30 15:04:58 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
e2f1fea6be
fix: refs #7277 error test
jsegarra added 2 commits 2024-09-02 09:44:16 +00:00
jgallego added 2 commits 2024-09-03 13:15:31 +00:00
jgallego requested review from jsegarra 2024-09-03 13:24:54 +00:00
jsegarra added 1 commit 2024-09-03 13:38:06 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
d54361a0bc
Merge branch 'dev' into 7277-RefundInvoices
jsegarra requested changes 2024-09-03 13:52:49 +00:00
Dismissed
@ -0,0 +80,4 @@
try {
await models.InvoiceOut.makePdfList(ctx, refundId);
} catch (e) {
throw new UserError('The invoices have been created but the PDFs could not be generated');
Member

Este texto no deberia tener traducción?

Este texto no deberia tener traducción?
jsegarra marked this conversation as resolved
@ -0,0 +65,4 @@
const originalInvoice = await models.InvoiceOut.findById(id);
if (!originalInvoice)
throw new UserError('Original invoice not found');
Member

traducción?

traducción?
@ -0,0 +113,4 @@
try {
await models.InvoiceOut.makePdfList(ctx, transferredInvoiceId);
} catch (e) {
throw new UserError('The transferred invoice has been created but the PDF could not be generated');
Member

traducción?

traducción?
jsegarra marked this conversation as resolved
@ -138,4 +138,3 @@
transferInvoice() {
const params = {
id: this.invoiceOut.id,
refFk: this.invoiceOut.ref,
Member

duda, en Lilium, has quitado este param. porque aquí no?
En Lilium has dejado id

duda, en Lilium, has quitado este param. porque aquí no? En Lilium has dejado id
jsegarra marked this conversation as resolved
jsegarra changed title from #7277-RefundInvoices to #7277 - RefundInvoices 2024-09-03 13:52:56 +00:00
jgallego added 2 commits 2024-09-04 08:25:04 +00:00
jgallego requested review from jsegarra 2024-09-04 08:26:21 +00:00
jsegarra requested changes 2024-09-04 14:13:26 +00:00
Dismissed
jsegarra left a comment
Member

Los e2e fallan
image

Los e2e fallan ![image](/attachments/9e10986a-bdfa-47e9-890a-ca48658cbb00)
Member

y despues de actualziar con dev
image

y despues de actualziar con dev ![image](/attachments/fc1f1b49-d2c0-4f19-b69d-e5410dbd6e67)
Author
Owner

image

![image](/attachments/f03153fe-13e0-4387-beea-69f998d2a519)
jgallego requested review from jsegarra 2024-09-05 07:21:20 +00:00
jsegarra approved these changes 2024-09-05 07:22:46 +00:00
jgallego merged commit 40a1b24403 into dev 2024-09-05 09:07:25 +00:00
jgallego deleted branch 7277-RefundInvoices 2024-09-05 09:07:25 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2904
No description provided.