verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

fix: refs #6900 fine tunning #2905

Merged
jorgep merged 5 commits from 6900-hotfix-fineTunning into master 2024-09-04 13:57:27 +00:00
Conversation 0 Commits 5 Files Changed 3 +6 -28
jorgep commented 2024-09-02 06:45:15 +00:00
Member
Copy Link
No description provided.
jorgep added 1 commit 2024-09-02 06:45:16 +00:00
gitea/salix/pipeline/pr-master There was a failure building this commit Details
cdaf8a7a67 fix: refs #6900 fine tunning
jorgep added 1 commit 2024-09-02 11:55:49 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
4ea1177d38 chore: refs #6900 fix test
jorgep reviewed 2024-09-02 11:57:01 +00:00
modules/invoiceIn/back/methods/invoice-in/specs/filter.spec.js Outdated
@ -47,29 +47,6 @@ describe('InvoiceIn filter()', () => {
}
});
it('should return the invoice in matching the serial number', async() => {
jorgep commented 2024-09-02 11:57:01 +00:00
Author
Member
Copy Link

Serial number está deprecado.

Serial number está deprecado.
jorgep reviewed 2024-09-02 11:57:34 +00:00
modules/invoiceIn/back/methods/invoice-in/specs/filter.spec.js
@ -159,3 +136,3 @@
const result = await models.InvoiceIn.filter(ctx, {}, options);
expect(result.length).toEqual(5);
expect(result.length).toEqual(6);
jorgep commented 2024-09-02 11:57:34 +00:00
Author
Member
Copy Link

ahora se filtra por issued en lugar de created.

ahora se filtra por issued en lugar de created.
jorgep changed title from WIP: fix: refs #6900 fine tunning to fix: refs #6900 fine tunning 2024-09-02 11:57:53 +00:00
jorgep requested review from jgallego 2024-09-02 12:08:32 +00:00
jorgep added the
CR / Tests passed
 label 2024-09-02 12:08:35 +00:00
jgallego approved these changes 2024-09-02 12:52:49 +00:00
jorgep added 1 commit 2024-09-03 10:52:22 +00:00
jorgep added 1 commit 2024-09-04 07:15:23 +00:00
jorgep added 1 commit 2024-09-04 13:55:28 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
ac5ff9e807 Merge branch 'master' into 6900-hotfix-fineTunning
jorgep merged commit 2ef289bf3a into master 2024-09-04 13:57:27 +00:00
jorgep deleted branch 6900-hotfix-fineTunning 2024-09-04 13:57:27 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2905
No description provided.
Delete Branch "6900-hotfix-fineTunning"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?