verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

fix: refs #7323 fetch from right source #2933

Merged
jorgep merged 4 commits from 7323-replaceWorkerDataSource into dev 2024-09-09 07:05:02 +00:00
Conversation 0 Commits 4 Files Changed 3 +25 -41
jorgep commented 2024-09-06 14:01:42 +00:00
Member
Copy Link
No description provided.
jorgep added 1 commit 2024-09-06 14:01:43 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
eb11e18df5 fix: refs #7323 fetch from right source
jorgep added 1 commit 2024-09-06 14:04:45 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
6065c056e2 chore: refs #7323 fix test
jorgep added 1 commit 2024-09-06 14:09:33 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
0a4bd0f2d5 chore: refs #7323 fix test
jorgep requested review from jgallego 2024-09-06 14:10:04 +00:00
jorgep reviewed 2024-09-06 14:12:02 +00:00
modules/worker/front/descriptor/index.js
@ -72,3 +39,1 @@
return this.getData(`Workers/${this.id}`, {filter})
.then(res => this.entity = res.data);
return this.getData('Workers/descriptor', {filter: {where: {id: this.id}}})
jorgep commented 2024-09-06 14:12:02 +00:00
Author
Member
Copy Link

Los scope devuelven arrays.

Los scope devuelven arrays.
jorgep added the
CR / Tests passed
 label 2024-09-06 14:14:04 +00:00
jorgep added 1 commit 2024-09-06 15:49:59 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
ba2c5cb209 chore: refs #7323 filter data
jorgep reviewed 2024-09-06 15:54:15 +00:00
modules/worker/back/models/worker.json
@ -143,6 +143,10 @@
],
"scopes": {
"descriptor": {
"fields": [
jorgep commented 2024-09-06 15:54:15 +00:00
Author
Member
Copy Link

Me he dado cuenta, que en el filtro original que había en salix se estaban devolviendo muchos datos de los que se quiere realmente. Ahora solo se pueden obtener los necesarios.

Me he dado cuenta, que en el filtro original que había en salix se estaban devolviendo muchos datos de los que se quiere realmente. Ahora solo se pueden obtener los necesarios.
jgallego approved these changes 2024-09-09 05:51:56 +00:00
jorgep merged commit af1cab44eb into dev 2024-09-09 07:05:02 +00:00
jorgep deleted branch 7323-replaceWorkerDataSource 2024-09-09 07:05:02 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2933
No description provided.
Delete Branch "7323-replaceWorkerDataSource"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?