verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

fix: refs #7213 change rounding problems #2943

Merged
guillermo merged 4 commits from 7213-changeRoundingProblem into master 2024-09-11 10:33:01 +00:00
Conversation 0 Commits 4 Files Changed 4 +22 -169
carlosap commented 2024-09-10 11:04:08 +00:00
Member
Copy Link
No description provided.
carlosap added 1 commit 2024-09-10 11:04:08 +00:00
gitea/salix/pipeline/pr-master There was a failure building this commit Details
0bbf10ca4f fix: refs #7213 change rounding problems
carlosap requested review from guillermo 2024-09-10 11:04:21 +00:00
guillermo requested changes 2024-09-10 11:07:19 +00:00
Dismissed
guillermo left a comment
Member
Copy Link

Revisa los tests, hay un error

Revisa los tests, hay un error
carlosap added 1 commit 2024-09-10 11:16:18 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
8fd7c1a8dd fix: refs #7213 change rounding problems
guillermo approved these changes 2024-09-10 13:01:27 +00:00
Dismissed
guillermo requested changes 2024-09-10 13:02:14 +00:00
Dismissed
db/routines/vn/procedures/sale_getProblems.sql Outdated
@ -209,2 +204,4 @@
) sub
ON DUPLICATE KEY UPDATE itemDelay = sub.problem, saleFk = sub.saleFk;
CALL buyUltimate(vWarehouseFk, vDate);
guillermo commented 2024-09-10 13:02:12 +00:00
Member
Copy Link

No falta el drop de la tabla generada?

No falta el drop de la tabla generada?
guillermo marked this conversation as resolved
guillermo requested changes 2024-09-10 13:02:43 +00:00
Dismissed
db/routines/vn/procedures/sale_getProblems.sql
@ -211,0 +206,4 @@
CALL buyUltimate(vWarehouseFk, vDate);
INSERT INTO tmp.sale_problems(ticketFk, hasRounding, saleFk)
SELECT ticketFk, problem ,saleFk
guillermo commented 2024-09-10 13:02:42 +00:00
Member
Copy Link

SELECT ticketFk, problem, saleFk

SELECT ticketFk, problem, saleFk
guillermo marked this conversation as resolved
carlosap added 1 commit 2024-09-11 08:15:40 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
ad8f27ea81 fix: refs #7213 change rounding problems
guillermo approved these changes 2024-09-11 10:26:36 +00:00
guillermo added 1 commit 2024-09-11 10:31:20 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
011c16180d fix: refs #7213 buyUltimate
guillermo merged commit 07f7f87c28 into master 2024-09-11 10:33:01 +00:00
guillermo deleted branch 7213-changeRoundingProblem 2024-09-11 10:33:01 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
guillermo
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2943
No description provided.
Delete Branch "7213-changeRoundingProblem"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?